399824 - Downloading a File Accessed via a URI with a Query Results in the Wrong File Name

Status: RESOLVED DUPLICATE of bug 387894

(SeaMonkey :: Download & File Handling, defect)

Description

[David E. Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 Mnenhy/0.7.5.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 Mnenhy/0.7.5.0

I attempted to download the new PrefBar 4.0 extension.  The link was <http://prefbar.mozdev.org/installation.html?get=prefbar4.0.xpi>.  The downloaded file was named installation.html and not prefbar4.0.xpi.  

This apparently is a symptom of the same problem reported in Firefox bug #299372.  However, repeated requests to generalize that bug report (e.g., make it Core in place of Firefox) have been ignored.  This new bug is therefore a SeaMonkey equivalent but not a duplicate (until #299372 become Core).  

Reproducible: Always




I notified Reimer (author of PrefBar) of the problem.  He changed his links in Mozdev so the problem can no longer be reproduced from his site.  However, that did not resolve the actual problem in SeaMonkey.  This problem likely also affects all other Gecko-based browsers (e.g., Camino).   

Note that the Summary and initial description of bug #299372 are quite confusing.  Neither that bug nor this one have anything to do with attachments.  The actual problem occurs when downloading a file via a link where the URI involves a query (indicated by ? in the URI).  The end of the path-file prior to the ? is used to name the local file.  Instead, the actual file-name should be used unless, of course, changed by the user in the Save As dialog window.  

It is possible that this problem does not affect direct installation of extensions by selecting a link.  I have not tested that.  However, it is quite likely that this problem affects all downloaded files accessed via a query URI, not merely .xpi files.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The summary of bug 299372 is correct, and it's in the correct component. The bug doesn't have anything to do with query parameters, and is specific to "Save Link As..." (it doesn't apply to other ways of downloading, e.g. a normal left click). That's why it's a Firefox specific bug. It only applies to downloads that have a Content-Disposition specified filename that doesn't match the filename in the URL. 

I don't know what this bug is about, because it doesn't have steps to reproduce, or a testcase.

Comment 2

[David E. Ross]

My assertion that this is equivalent to bug #299372 resulted from Reimer's reply to my original complaint that his link to the PrefBar .xpi file resulted in a wrong name for the file.  His reply referred to bug #299372.  

To recreate the problem:  

1.  Go to <http://accountex.mozdev.org/en_beta.html>.  

2.  At the bottom of the Download section, place your cursor over the link for accountex-0.2.90-de-tb.xpi.  

3.  Right-click and select Save Link Target As from the pull-down context menu.  
 
The saved file will be named download.php.  It should be named accountex-0.2.90-de-tb.xpi.  

Since this is not the same as #299372, is this perhaps a Core: File Handling bug instead of a Mozilla Suite: Download Manager bug?  Nevertheless, the issue of whether #299372 affects other products has never been answered.  

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Given those steps to reproduce, this is the same issue as bug 299372. The "bug (an intentional change) is in contentAreaUtils.js. If SeaMonkey uses the toolkit version of that file, this would be fixed by a patch for bug 299372. If SeaMonkey doesn't yet use the toolkit version of that file, which I think is the case, SeaMonkey will likely need to be patched separately.

Comment 4

[Serge Gautherie (:sgautherie)]

(I didn't read everything.)

David,
Isn't this a duplicate of your bug 387894 ?

Comment 5

[David E. Ross]

Yes, it is a duplicate.  I'm closing this in favor of the older bug in order to maintain a history of when this was first reported.