399835 - Need pref for IMAP expunge threshold

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jeff Beckley]

When an IMAP account is using the IMAP delete model (i.e. deleted messages are not removed from the mailbox right away, but instead just marked as deleted), messages marked as deleted don't get permanently removed ("expunged" in IMAP terminology) until a certain number of messages have been marked as deleted.

Currently, that threshold is hard-coded at 20 messages.  It should instead be a preference which the user can set.

Comment 1

[Jeff Beckley]

Attachment: Pref added and used

Comment 2

[Jeff Beckley]

Attachment: Pref added and used

Here's an implementation of the pref, which is named "mail.imap.expunge_threshold_number".

Comment 3

[Jeff Beckley]

Re-assigning to Dale Wiggins <[e-mail]> since he's the one that wrote the code (I'm just submitting it for him).

Comment 4

[Magnus Melin [:mkmelin]]

+static PRBool gExpungeThreshold = 20;

PRInt32 might work better;)

Comment 5

[Jeff Beckley]

Attachment: Fix for pref type

Argh!  Had that change locally, but it didn't make it in to the first patch.  Here it is now.

Comment 6

[David :Bienvenu]

Comment on attachment 284951 [details] [diff] [review]
Fix for pref type

looks good, thx

Comment 7

[Scott MacGregor]

Comment on attachment 284951 [details] [diff] [review]
Fix for pref type

looks good!

Comment 8

[Magnus Melin [:mkmelin]]

Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.308; previous revision: 3.307
done
Checking in mailnews/imap/src/nsImapProtocol.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v  <--  nsImapProtocol.cpp
new revision: 1.672; previous revision: 1.671
done

->FIXED