399838 - Automatically init (not open) the download manager when starting the app

Status: VERIFIED FIXED

(Toolkit :: Downloads API, enhancement, P1)

Description

[Ed Lee :Mardak]

From bug 399817 comment #0:

A separate bug should be filed to init the download manager when starting the
app.. similar to session restore. So if we always restart dlmgr, we won't the
code in session restore either.


Without a fix for this bug, even with bug 399817 fixed, the auto-resume downloads will only resume /after/ the download manager is opened.

How should this be done without impacting startup time too much? The dlmgr doesn't have to get inited exactly when the app starts, but after the homepage loads could be good.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

I'm not sure if this is the most appropriate place to do this, but it's probably the least amount of code change possible. ;) I'm not sure how this affects Ts, etc. The download manager doesn't necessarily have to start with 0 timeout.. it could be something arbitrarily higher.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 285042 [details] [diff] [review]
v1

this really should not affect Ts, as it runs after the first window loads. r=me.

Comment 3

[Jesse Ruderman]

http://quotes.burntelectrons.org/2851

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #3)
> http://quotes.burntelectrons.org/2851
> 

spun off to bug 400102

Comment 5

[Shawn Wilsher :sdwilsh]

Note, we do have Bug 386605.

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to comment #5)
> Note, we do have Bug 386605.
> 

that doesn't affect Ts's shortcomings, only our methods of gaming it.

s/delayedStartup()/new delayed startup event/.

Comment 7

[Ed Lee :Mardak]

For a litmus test, quit firefox with a download at ~90% going then restart firefox. The download should finish without opening the download manager (the all downloads done message should pop up).

Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.81; previous revision: 1.80
done

Comment 8

[Shawn Wilsher :sdwilsh]

Backing out due to Bug 401052.

Also, this fix isn't technically correct since this will only do that for browser, but not any other toolkit app.

*cough*delayed-startup*cough*

Comment 9

[Ed Lee :Mardak]

dietrich: Any suggestions now that we know the current patch affects Ts? A simple hack would just be to setTimeout with a non-0 value like.. 60000 -- if the user opens the download manager before that, the downloads will auto-resume then, if not downloads will auto-resume at the 1 minute mark.

sdwilsh: If we just want this start-dlmgr-at-start feature for just firefox for now, this should be filed under something else? Would the delayed-startup-event be accessible for all toolkit users?

Comment 10

[Shawn Wilsher :sdwilsh]

we already have a delayed startup for Firefox, but we really should be doing that for toolkit.

Comment 11

[Ed Lee :Mardak]

Comment on attachment 285042 [details] [diff] [review]
v1

Where's the delayed start up for Firefox? Initializing the download manager service at startup could be something for each app to choose if they want it or not.

>+      aWindow.setTimeout(this.retryDownloads, 0);
s/0/10000/ ?

Comment 12

[Ed Lee :Mardak]

Oh, probably meant browser/base/content/browser.js's delayedStartup ?

Comment 13

[Mike Connor [:mconnor]]

That's the one.  As it stands, I'm okay with that as a reasonable step for apps.  Not the ideal solution, but good enough for now (need to document it!)

Comment 14

[Ed Lee :Mardak]

Attachment: v2

Starts the download manager after 10 seconds.

Tested with an almost-complete download and quitting the app. Restarted and the growl notification showed up and ~12 seconds later the 'all downloads complete' notification showed up.

Comment 15

[Ed Lee :Mardak]

Loading the service before the user opens the download manager window will help it show up faster. (bug 404006)

Comment 16

[Shawn Wilsher :sdwilsh]

I like this approach a lot better.

Comment 17

[Mike Connor [:mconnor]]

Comment on attachment 293301 [details] [diff] [review]
v2

please make sure any appropriate docs around the dlmgr know that to get auto-resume, you need to init the service in this way?

Comment 18

[Ed Lee :Mardak]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.914; previous revision: 1.913
done
Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.88; previous revision: 1.87
done

Comment 19

[Ed Lee :Mardak]

sdwilsh: Where to find the docs about using download manager?

Watching Ts to see if this affects it again.

Comment 20

[Shawn Wilsher :sdwilsh]

What docs?  If there's a page on nsIDownloadManager, I suppose that's the best place for it...

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5021


Verified FIXED using ftp://ftp.mozilla.org/pub/diskimages/Firefox1.0PR.iso with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

VM cut-and-paste-- :-(

Last build ID should be Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre