399879 - Sisyphus: add a -v switch for verbose output in files

Status: RESOLVED FIXED

(Testing Graveyard :: Sisyphus, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Currently, sisyphus outputs the name of the log and redirects output to that logfile. I'd like to have a verbose option where instead of just outputting to the logfile, the output is also tee'd to stdout.

e.g., (in builder.sh) line 114: clean.sh -p $product -b $branch -T $buildtype $extraflag | tee $TEST_LOG 2>&1

Comment 1

[Bob Clary [:bc] (inactive)]

Just to be clear, Do you just want this on the builder.sh output or as an option on all scripts that generate log files?

Comment 2

[Rob Campbell [:rc] (:robcee)]

I'd like it available on all of the log-file generating scripts.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: patch to sisyphus scripts

patches bin/builder.sh, and bin/tester.sh

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: patch to js test scripts

patch to js tests runtests.sh (with minor tag-along patch to test.sh).

This has a problem since runtests.sh uses stdout to collect the names of the log files to be post processed. Using -v will pollute the list of file names since there is no current method of distinguishing the logfiles from the verbose log output.

Rob, I think that changing the display of log file names on stdout to include an identifier allowing the script to strip the verbose output would solve the problem but would require buildbot to strip the identifier from stdout when it picks up the log file names. Buildbot would need something similar if it was attempting to run the tests with verbose.

example:

log: /work/mozilla/mozilla.com/test.mozilla.com/www/results/2007-10-21-19-22-01-0400,js,1.9.0,,linux,martha.bclary.com,checkout.log

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: patch to sisyphus scripts (v2)

adds log: prefix

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: patch to js test scripts (v2)

adds log: prefix

Comment 7

[Rob Campbell [:rc] (:robcee)]

this should work nicely. Thanks!

Comment 8

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/testing/sisyphus/bin/builder.sh,v  <--  builder.sh
new revision: 1.5; previous revision: 1.4

/cvsroot/mozilla/testing/sisyphus/bin/tester.sh,v  <--  tester.sh
new revision: 1.6; previous revision: 1.5

/cvsroot/mozilla/js/tests/known-failures.pl,v  <--  known-failures.pl
new revision: 1.2; previous revision: 1.1

/cvsroot/mozilla/js/tests/runtests.sh,v  <--  runtests.sh
new revision: 1.3; previous revision: 1.2

/cvsroot/mozilla/js/tests/test.sh,v  <--  test.sh
new revision: 1.5; previous revision: 1.4
done

Comment 9

[(not currently active) Ted Mielczarek]

Mass move of Sisyphus bugs to Testing : Sisyphus. Filter on SisyphusMassMove to ignore.