399895 - Extension update notification should be a named notification

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

The new named notification allows OSX users to control aspects of each type of notification, we should use this in the extension update alert.

Comment 1

[Shawn Wilsher :sdwilsh]

To give a bit more details about what needs to be done here...

The function calls to showAlertNotification in nsExtensionManager.js.in should pass in a localized name for the name argument [1].  You'll use the BundleManager object in this file to get the localized version of the name.  You probably want to put the localized name in the file extensions.properties

This next part isn't so well documented sadly, so I'm going to point to some IDL's which define the methods needed to do this.  You'll need to register with nsIObserverService after "profile-after-change" for "before-growl-registration".  When you get notified about this topic, you'll have an instance of nsINotificationsList [2] (you'll have to QueryInterface aSubject to get it) where you can register this named notification.  If you do not register, it will not work properly.

[1] https://developer.mozilla.org/en/nsIAlertsService#showAlertNotification()
[2] http://mxr.mozilla.org/mozilla-central/source/toolkit/components/alerts/public/nsINotificationsList.idl

Comment 2

[Dave Townsend [:mossop]]

I'm a little concerned that fixing this now might just amount to wasted effort. We're currently looking at what could be some pretty wide scope changes to the extension manager which include avoiding loading it during startup and as I understand it this bug cannot be fixed without doing that.

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> I'm a little concerned that fixing this now might just amount to wasted effort.
> We're currently looking at what could be some pretty wide scope changes to the
> extension manager which include avoiding loading it during startup and as I
> understand it this bug cannot be fixed without doing that.
You could always create a smaller component that just does the registering at startup and isn't the whole object.  There are other ways to work around that as well, so I'm not sure that that alone is enough to not take this.

Comment 4

[Dave Townsend [:mossop]]

Creating a dedicated component just to handle this seems like a complete waste. How many people do we think even use this feature?

I'd be more interested to see the alerts service use the category manager to find components that want to be registered and to defer that registration until the first time growl is actually used. I can't see an obvious reason why this wouldn't work and it ought to be a Ts win too. Not to mention it would stop cluttering up growl with registrations for XUL applications that never even display an alert.

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> Creating a dedicated component just to handle this seems like a complete waste.
There has been talk in the past that we have some small component that registers all the toolkit notifications.

> How many people do we think even use this feature?
It's how we are supposed to use Growl.  All other applications that use Growl actually register their different notifications.  It gives the user more control about what they see.

> I'd be more interested to see the alerts service use the category manager to
> find components that want to be registered and to defer that registration until
> the first time growl is actually used. I can't see an obvious reason why this
> wouldn't work and it ought to be a Ts win too. Not to mention it would stop
> cluttering up growl with registrations for XUL applications that never even
> display an alert.
Using the category manager would be good, but it'd be a crappy user experience to not register with growl until we first need to use it.  All applications that use Growl register at startup.  I mean, if we want to be even more different on the mac...

Comment 6

[Dave Townsend [:mossop]]

This bug is no longer relevant