Closed Bug 399900 Opened 17 years ago Closed 17 years ago

Bootstrap "Stage" step should throw error if locale XPIs are not found

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: bhearsum)

References

Details

Attachments

(1 file)

[checked in] check for 'ASSERT' and 'FAIL' in verify-locales.pl log
1.05 KB, patch
rhelmer
: review+
Details | Diff | Splinter Review 
Currently the windows-xpi directory must be copied manually during the signing step. This was missed for Firefox 2.0.0.7 (bug 399897) and Firefox 2.0.0.8 (during RC2 candidate stage).

We should at least check for the existence of the xpi directory, if not verify that every expected locale.xpi is present, as a Verify method of Bootstrap::Stage.pm
Summary: Bootstrap "Stage" step should throw error is locale XPIs are not found → Bootstrap "Stage" step should throw error if locale XPIs are not found
Priority: -- → P3
Assignee: build → nobody
QA Contact: mozpreed → build
Assignee: nobody → bhearsum
Priority: P3 → P2
Status: NEW → ASSIGNED
Unless I'm mistaken, what you've described in comment #0 is done in verify-locales.pl (in the VerifyXPIDirectory() function). This patch simply does a couple of CheckLog()'s on the verify-locales log so that Bootstrap::Step::Stage will fail if it sees a 'FAIL' or an 'ASSERT'.
Attachment #294682 - Flags: review?(rhelmer)
Attachment #294682 - Flags: review?(rhelmer) → review+
Checking in Bootstrap/Step/Stage.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Stage.pm,v  <--  Stage.pm
new revision: 1.31; previous revision: 1.30
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #294682 - Attachment description: check for 'ASSERT' and 'FAIL' in verify-locales.pl log → [checked in] check for 'ASSERT' and 'FAIL' in verify-locales.pl log
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: