Closed
Bug 399960
Opened 18 years ago
Closed 18 years ago
"Assertion failure: !JS_IsExceptionPending(cx)" with |new Option|
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: mrbkap)
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
146 bytes,
text/html
|
Details | |
|
2.04 KB,
patch
|
jst
:
review+
jst
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase triggers:
Assertion failure: !JS_IsExceptionPending(cx), at /Users/jruderman/trunk/mozilla/js/src/jsiter.c:278
| Assignee | ||
Comment 1•18 years ago
|
||
We need to ensure that we return an error if converting the object to a string fails.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #285548 -
Flags: superreview?(jst)
Attachment #285548 -
Flags: review?(jst)
Comment 2•18 years ago
|
||
Comment on attachment 285548 [details] [diff] [review]
diff -w of the fix
r+sr=jst
Attachment #285548 -
Flags: superreview?(jst)
Attachment #285548 -
Flags: superreview+
Attachment #285548 -
Flags: review?(jst)
Attachment #285548 -
Flags: review+
| Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 285548 [details] [diff] [review]
diff -w of the fix
This is trivially correct and can clear up some potential hard to track down bugs.
Attachment #285548 -
Flags: approval1.9?
Updated•18 years ago
|
Attachment #285548 -
Flags: approval1.9? → approval1.9+
| Assignee | ||
Comment 4•18 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•