400025 - SVG stroke on text is rendered on... something else

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Wesley Johnston (:wesj)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101605 Minefield/3.0a9pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007101605 Minefield/3.0a9pre

The stroke one svg text is being rendered on some separate box. This started on builds after 10/10

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: stroke on text testcase

A testcase for rendering stroke on text

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Image of the current rendering and previous rendering

The image shows the rendering as seen with todays build, and with a build from 10/9/07.

Comment 3

[Robert Longson [:longsonr]]

Regression from bug 384681. Backing that out fixes it.

It seems like strokes are rendered much too large

Comment 5

[tor]

_cairo_win32_transform_FIXED_to_fixed is assuming that the GDI "FIXED" type is of the same format as _cairo_fixed_t.  This worked when cairo was using 16.16, but gives the incorrect result now that we're using 24.8.

Comment 6

[Robert Longson [:longsonr]]

Attachment: patch

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 285566 [details] [diff] [review]
patch

Blah, I attached basically this same patch last friday but apparently dropped off the net before it took in bugzilla.  This looks fine

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 285566 [details] [diff] [review]
patch

whoops, forgot we're in approvals-only mode

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 285566 [details] [diff] [review]
patch

Massive confusion regarding approvals.  Land away!

Comment 10

[Robert Longson [:longsonr]]

checked in.

Comment 11

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007102605 Minefield/3.0a9pre

-> Verified fixed