400092 - Expand permission manager type limits

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Daniel Veditz [:dveditz]]

The current Permission Manager implementation is limited to eight "types". We were already using four that I know of in Firefox2 (cookie, image, popup, install), offline-apps are using another (almost used two before we noticed the limit), XForms uses another ("xforms-xd"), and who knows how many extensions.

Once the Permission Manager has eight strings in its list it simply won't store any more.

While we're at it we should reconsider whether 15 permissions is a large enough limit (and whether the prohibition on 0 values is reasonable).

Both limits appear to be based on memory-use concerns, although in the case of permissions there's currently room for up to 256 values.

Expanding either of these limits might raise problems if the hostperm.1 file were shared between a FF2 and a FF3 profile -- the older build would drop any entries that exceeded either limit. We may have to rev the file anyway to address some IDN concerns I'm going to file in a separate bug.

Comment 1

[Daniel Veditz [:dveditz]]

The IDN concerns are in bug 400097

Comment 2

[[e-mail]]

-> me

Comment 3

[(not currently active) Ted Mielczarek]

blocking+ for the potential dataloss issues.

Comment 4

[[e-mail]]

fixed per bug 400097.