40031 - "Netscape HTTP Cookie File" in mozilla's cookie file

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[Henrik Gemal]

Why does it say:
"Netscape HTTP Cookie File"

in the cookies.txt file for Mozilla.

Shouldn't it say:
"Mozilla HTTP Cookie File"
or just
"Mozilla Cookie File"

Comment 1

[Stephen P. Morse]

Or simply "HTTP Cookie File" so that it can be used by both Netsape and Mozilla.

Comment 2

[Stephen P. Morse]

Same applies to the cookperm.txt file.

Comment 3

[Henrik Gemal]

What about the bookmarks.html file:
<!DOCTYPE NETSCAPE-Bookmark-file-1>

should I file another bug?

Comment 4

[Stephen P. Morse]

Yes, please do put that into a separate bug.  Mainly because bookmarks are not 
my domain so these changes would be done by different people and it would be 
hard to track it if it was all in one bug report.  Both cookies.txt and 
cookperm.txt are mine so we can cover those two with this one report.

Comment 5

[Stephen P. Morse]

These files are really not user visible so this fix isn't necessary.  If they 
were user-visible, then we would also have to localize them file -- e.g., have 
them say mozilla or netscape in japanese characters in the japanese version.  
Clearly we are not going to go that far.

Comment 6

[Henrik Gemal]

Why not just write:
"HTTP Cookie File"
?
Since this is what it is!

Since Netscape != Mozilla it would be strange to find references to Netscape in 
Mozilla files.

Comment 7

[Stephen P. Morse]

For the same reason I'm not writing it in japanese for the japanese version.  
Because this is not a user-visible file.

Comment 8

[Henrik Gemal]

I really dont see why you have to translate this???

In fx pref.js you also have:
# Mozilla User Preferences
You dont translate that!!!

I'm really close to reopen this...:)

Comment 9

[Stephen P. Morse]

If you feel that strongly about it, then please do reopen it, assign it to 
yourself, and check in the change.

Comment 10

[Henrik Gemal]

I dont have cvs permission, but I would gladly provide a diff patch...

Comment 11

[Henrik Gemal]

Here is the diff...

Comment 12

[Henrik Gemal]

Attachment: Removes Netscape from cookie files

Comment 13

[Stephen P. Morse]

You'll need to get the necessary permissions/approvals if you want to have 
this checked in.  They are:

1. Module owner: that's me -- approved
2. Mozilla coordinator: that's waterson or brendan

Comment 14

[Henrik Gemal]

Sorry for the spam, but how do I get this approval? CVS contribution form?

Comment 15

[Stephen P. Morse]

Simply send e-mail to [e-mail] or [e-mail] (or maybe 
[e-mail] or [e-mail]).

Comment 16

[Stephen P. Morse]

Patch checked in.

Comment 17

[Tom Everingham]

verified:
WinNT 2000070708
Linux 2000070710