Closed Bug 400322 Opened 17 years ago Closed 15 years ago

"ASSERTION: nsStandardURL not thread-safe" (nsJARInputThunk marked as threadsafe uses nsJARURI in a non threadsafe manner)

Categories

(Core :: Networking: JAR, defect)

Product:
Core
Component:
Networking: JAR
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: jruderman, Assigned: timeless)

References

(
URL
)

Details

(Keywords: assertion)

Attachments

(1 file, 2 obsolete files)

fixed
1.79 KB, patch
timeless
: review+
Biesinger
: superreview+
Details | Diff | Splinter Review
Attached file stack trace (obsolete) — 
I hit this assertion a few hours ago:

###!!! ASSERTION: nsStandardURL not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /Users/jruderman/trunk/mozilla/netwerk/base/src/nsStandardURL.cpp, line 931

I can't reproduce, but I do have a stack trace, thanks to XPCOM_DEBUG_BREAK=stack and fix-macosx-stack.pl.

I think the assertion was triggered by a missing-plugin bar appearing.  Maybe that required Firefox to load some extra script or the missing-plugin image from a jar file?
Flags: blocking1.9?
Jesse - why did you nom this for blocking?
Because thread safety violations scare me.  (Should they scare me?)
Minusing - if we get a reproducible test case and/or if we are security concerned please re-nom
Flags: blocking1.9? → blocking1.9-
URL: http://mxr.mozilla.org/mozilla-centra...
Summary: "ASSERTION: nsStandardURL not thread-safe" within nsJARURI::~nsJARURI → "ASSERTION: nsStandardURL not thread-safe" (nsJARInputThunk marked as threadsafe uses nsJARURI in a non threadsafe manner)
Target Milestone: --- → psm1.3
Assignee: nobody → timeless
Status: NEW → ASSIGNED

        Attachment #336610 -
        Flags: review?(cbiesinger)

    
    

    
  
Comment on attachment 336610 [details] [diff] [review]
don't hold uris they're for the main thread only

+        NS_ENSURE_STATE(mJarDirSpec.IsEmpty());

Don't you mean !mJarDirSpec.IsEmpty()?

        Attachment #336610 -
        Flags: review?(cbiesinger) → review+

    
  
Target Milestone: psm1.3 → mozilla2.0

    
    

    
  
timeless: one little review comment in comment 5 saying you got the patch backward ;) and you need to request sr.
Whiteboard: [timeless: need new patch][timeless: request sr]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fixed
        — 
          — Splinter Review
      

    


  

        Attachment #285405 -
        Attachment is obsolete: true

        Attachment #336610 -
        Attachment is obsolete: true

        Attachment #355311 -
        Flags: review+

        Attachment #355311 -
        Flags: superreview?(cbiesinger)
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [timeless: need new patch][timeless: request sr] → [timeless: pending-sr]
Target Milestone: mozilla2.0 → mozilla1.9.2a1

        Attachment #355311 -
        Flags: superreview?(cbiesinger) → superreview+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4c8363cef88b
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [timeless: pending-sr]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: