Closed Bug 400322 Opened 15 years ago Closed 13 years ago
Standard URL not thread-safe" (ns JARInput Thunk marked as threadsafe uses ns JARURI in a non threadsafe manner)
I hit this assertion a few hours ago: ###!!! ASSERTION: nsStandardURL not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /Users/jruderman/trunk/mozilla/netwerk/base/src/nsStandardURL.cpp, line 931 I can't reproduce, but I do have a stack trace, thanks to XPCOM_DEBUG_BREAK=stack and fix-macosx-stack.pl. I think the assertion was triggered by a missing-plugin bar appearing. Maybe that required Firefox to load some extra script or the missing-plugin image from a jar file?
Jesse - why did you nom this for blocking?
Because thread safety violations scare me. (Should they scare me?)
Minusing - if we get a reproducible test case and/or if we are security concerned please re-nom
Flags: blocking1.9? → blocking1.9-
Summary: "ASSERTION: nsStandardURL not thread-safe" within nsJARURI::~nsJARURI → "ASSERTION: nsStandardURL not thread-safe" (nsJARInputThunk marked as threadsafe uses nsJARURI in a non threadsafe manner)
Target Milestone: --- → psm1.3
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #336610 - Flags: review?(cbiesinger)
Comment on attachment 336610 [details] [diff] [review] don't hold uris they're for the main thread only + NS_ENSURE_STATE(mJarDirSpec.IsEmpty()); Don't you mean !mJarDirSpec.IsEmpty()?
Attachment #336610 - Flags: review?(cbiesinger) → review+
timeless: one little review comment in comment 5 saying you got the patch backward ;) and you need to request sr.
Whiteboard: [timeless: need new patch][timeless: request sr]
Attachment #355311 - Flags: superreview?(cbiesinger)
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [timeless: need new patch][timeless: request sr] → [timeless: pending-sr]
Target Milestone: mozilla2.0 → mozilla1.9.2a1
13 years ago
Attachment #355311 - Flags: superreview?(cbiesinger) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [timeless: pending-sr]
You need to log in before you can comment on or make changes to this bug.