Created attachment 285405 [details] stack trace I hit this assertion a few hours ago: ###!!! ASSERTION: nsStandardURL not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file /Users/jruderman/trunk/mozilla/netwerk/base/src/nsStandardURL.cpp, line 931 I can't reproduce, but I do have a stack trace, thanks to XPCOM_DEBUG_BREAK=stack and fix-macosx-stack.pl. I think the assertion was triggered by a missing-plugin bar appearing. Maybe that required Firefox to load some extra script or the missing-plugin image from a jar file?
Jesse - why did you nom this for blocking?
Because thread safety violations scare me. (Should they scare me?)
Minusing - if we get a reproducible test case and/or if we are security concerned please re-nom
Created attachment 336610 [details] [diff] [review] don't hold uris they're for the main thread only
Comment on attachment 336610 [details] [diff] [review] don't hold uris they're for the main thread only + NS_ENSURE_STATE(mJarDirSpec.IsEmpty()); Don't you mean !mJarDirSpec.IsEmpty()?
timeless: one little review comment in comment 5 saying you got the patch backward ;) and you need to request sr.
Created attachment 355311 [details] [diff] [review] fixed
9 years ago