Closed
Bug 400360
Opened 17 years ago
Closed 17 years ago
nsLDAPAutoCompleteSession leaks nsILDAPConnection
Categories
(MailNews Core :: LDAP Integration, defect)
MailNews Core
LDAP Integration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: simon, Assigned: simon)
Details
(Keywords: memory-leak, regression)
Attachments
(1 file)
|
728 bytes,
patch
|
standard8
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
nsLDAPAutoCompleteSession has a non-nsCOMptr, manually reference counted, copy of the current LDAP connection held in mConnection. This is manually reference counted in, and released when the connection becomes UNBOUND. However, if the nsLDAPAutoCompleteSession object goes out of scope without the connection being unbound, the connection is leaked. This leads to Thunderbird hanging on exit.
|
Assignee | |
Comment 1•17 years ago
|
||
Fix the leak, by RELEASEing the connection in the destructor.
|
||
Comment 2•17 years ago
|
||
FWIW this was a regression caused by my patch on bug 398059.
Keywords: regression
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 285457 [details] [diff] [review] Release connection when object is destroyed Yep, that's much better. Thanks for finding this.
Attachment #285457 -
Flags: review?(bugzilla) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #285457 -
Flags: superreview?(bienvenu)
|
||
Comment 4•17 years ago
|
||
Comment on attachment 285457 [details] [diff] [review] Release connection when object is destroyed thx, Simon.
Attachment #285457 -
Flags: superreview?(bienvenu) → superreview+
|
|
||
Comment 5•17 years ago
|
||
Checked in: /cvsroot/mozilla/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp,v <-- nsLDAPAutoCompleteSession.cpp new revision: 1.52; previous revision: 1.51 Thanks Simon.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•