Closed Bug 400369 Opened 14 years ago Closed 14 years ago

List markers (bullets) positioned incorrectly for left- and center-aligned list items in RTL lists

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: uriber, Assigned: uriber)

References

Details

(Keywords: rtl, testcase)

Attachments

(2 files)

Attached file testcase
In an RTL list, items which are styled with "text-align:left" or "text-align:center" still have their markers right-aligned.
Furthermore, for "text-align:left", the marker position is not updated when the list's width is changed (i.e. by resizing the window).
So, what this bug report is requesting is the "small fix" mentioned in bug 140611 comment #22.
Too bad Lina is no longer around, and it could take me quite some time to figure what this small fix actually is...
Attached patch patchSplinter Review
Move the bullet left so that it's next to the rest of the line, then adjust its position together with the rest of the line (as done for LTR).
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #285612 - Flags: superreview?(roc)
Attachment #285612 - Flags: review?(smontagu)
Attachment #285612 - Flags: review?(smontagu) → review+
Attachment #285612 - Flags: superreview?(roc)
Attachment #285612 - Flags: superreview+
Attachment #285612 - Flags: approval1.9?
Uri, do you want to check this in yourself or get someone else to do it for you?
Given the restrictions on the timing of checkins (which won't necessarily match my schedule), I'd appreciate it if someone can handle this for me. Thanks.
Checking in layout/generic/nsLineLayout.cpp;
/cvsroot/mozilla/layout/generic/nsLineLayout.cpp,v  <--  nsLineLayout.cpp
new revision: 3.281; previous revision: 3.280
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Depends on: 410503
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.