List markers (bullets) positioned incorrectly for left- and center-aligned list items in RTL lists

RESOLVED FIXED in mozilla1.9beta2

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: uriber, Assigned: uriber)

Tracking

({rtl, testcase})

Trunk
mozilla1.9beta2
rtl, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Created attachment 285460 [details]
testcase

In an RTL list, items which are styled with "text-align:left" or "text-align:center" still have their markers right-aligned.
Furthermore, for "text-align:left", the marker position is not updated when the list's width is changed (i.e. by resizing the window).
(Assignee)

Comment 1

11 years ago
So, what this bug report is requesting is the "small fix" mentioned in bug 140611 comment #22.
Too bad Lina is no longer around, and it could take me quite some time to figure what this small fix actually is...
(Assignee)

Comment 2

11 years ago
Created attachment 285612 [details] [diff] [review]
patch

Move the bullet left so that it's next to the rest of the line, then adjust its position together with the rest of the line (as done for LTR).
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #285612 - Flags: superreview?(roc)
Attachment #285612 - Flags: review?(smontagu)

Updated

11 years ago
Attachment #285612 - Flags: review?(smontagu) → review+
Attachment #285612 - Flags: superreview?(roc)
Attachment #285612 - Flags: superreview+
Attachment #285612 - Flags: approval1.9?
Attachment #285612 - Flags: approval1.9? → approval1.9+
Uri, do you want to check this in yourself or get someone else to do it for you?
(Assignee)

Comment 4

11 years ago
Given the restrictions on the timing of checkins (which won't necessarily match my schedule), I'd appreciate it if someone can handle this for me. Thanks.
Sure.
Keywords: checkin-needed
Checking in layout/generic/nsLineLayout.cpp;
/cvsroot/mozilla/layout/generic/nsLineLayout.cpp,v  <--  nsLineLayout.cpp
new revision: 3.281; previous revision: 3.280
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
(Assignee)

Updated

11 years ago
Depends on: 410503

Comment 7

11 years ago
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl

Updated

10 years ago
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.