400460 - appPicker.css should be moved to /mozapps/skin/ for themers

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Alfred Kayser]

Bug 348808 – use application selector instead of file selector dialog when picking helper apps, introduced 'appPicker.css', but this should have been placed in /skin/, as it is only about UI styling, and themers should be able to override/change this styling for their theme.

Comment 1

[Jim Mathies [:jimm]]

Ok, I've moved copies into the following places and removed the old one. 
 
\toolkit\themes\pinstripe\global
\toolkit\themes\winstripe\global

I'll post a patch here in a bit once I've tested it.

Technically the pinstripe one isn't needed yet since this isn't on mac, but I've put it in there anyway since I blieve someone is working on that.

Comment 2

[Jim Mathies [:jimm]]

Attachment: appicker.css move

Comment 3

[Jim Mathies [:jimm]]

I'm not entirely clear on how this should be setup. I've made dupes of appPicker.css in pinstripe and winstripe, but I wonder if I should just move it to one location and reference that in the other through the jar.mn file. 

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Nominating for blocking, as I suspect this is actually wanted.

I'm not sure which strategy is preferred, but I bet Gavin would know...

Comment 5

[:Gavin Sharp [email: [e-mail]]]

If it's the same file for both Windows/Linux and Mac, you can just put it in Winstripe and use a relative path in the Pinstripe jar.mn (I notice we already do this for about.css, from the context of that patch). If we ever need them to differ per-platform we can split them out.

Comment 6

[Jim Mathies [:jimm]]

Thanks for the feedback. Patch coming up with a relative path for the pinstripe theme. 

Comment 7

[Jim Mathies [:jimm]]

Attachment: appicker.css move v.2

along with applying the patch, appPicker.css needs to be moved from: 

/toolkit/components/apppicker/content

to

/toolkit/themes/winstripe/global

Comment 8

[Reed Loden [:reed]]

Checking in toolkit/components/apppicker/jar.mn;
/cvsroot/mozilla/toolkit/components/apppicker/jar.mn,v  <--  jar.mn
new revision: 1.2; previous revision: 1.1
done
Removing toolkit/components/apppicker/content/appPicker.css;
/cvsroot/mozilla/toolkit/components/apppicker/content/appPicker.css,v  <--  appPicker.css
new revision: delete; previous revision: 1.1
done
Checking in toolkit/components/apppicker/content/appPicker.xul;
/cvsroot/mozilla/toolkit/components/apppicker/content/appPicker.xul,v  <--  appPicker.xul
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/pinstripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/jar.mn,v  <--  jar.mn
new revision: 1.37; previous revision: 1.36
done
RCS file: /cvsroot/mozilla/toolkit/themes/winstripe/global/appPicker.css,v
done
Checking in toolkit/themes/winstripe/global/appPicker.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/appPicker.css,v  <--  appPicker.css
initial revision: 1.1
done
Checking in toolkit/themes/winstripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v  <--  jar.mn
new revision: 1.39; previous revision: 1.38
done

Comment 9

[Tony Chung [:tchung]]

Reporter, can you verify this is fixed?  Thanks.