400473 - proto handler dialog needs a11y love

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P3)

Description

[cmtalbert]

Attachment: Screen Shot of Mac UI

The Application selector is still missing icons for each application, and when it first runs it comes up too small such that the OK and Cancel buttons are trimmed off.

The dialog is resizable, yes, but it should first appear to be the proper size.

Also (judging from the DOM Inspector), it appears that we are missing an Access Key for the "Remember this selection" checkbox.

Should this be three bugs, or can both these things be tracked here?

== Steps to Reproduce ==
1. Open Minefield.
2. Click on this link: webcal://info.vassar.edu/calendar/calendars/campuscalendar.ics
3. Note the state of the application selector dialog.

== Expected Behaviors ==
* There are icons for the Applications (at least default icons at this point)
* The dialog is the proper size
* Proper Access keys are included for all parts of the dialog (looks like they are used everywhere else, except the "Remember this" checkbox).

== Actual ==
* Neither of these ar true.

Attaching a screen shot of the UI.

If we are going to publicize our handler-test.mozilla.org website, and invite more people to experience this dialog, then I think we should really try to fix these issues for M9.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Sizing should now be fixed.  Default handler icons are tracked by another bug.  Morphing this into accessibility-only bug and requesting blocking.

Comment 2

[Florian Quèze [:florian]]

Attachment: patch v1

Comment 3

[Florian Quèze [:florian]]

Checking in toolkit/locales/en-US/chrome/mozapps/handling/handling.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/handling/handling.properties,v  <--  handling.properties
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/mozapps/handling/src/nsContentDispatchChooser.js;
/cvsroot/mozilla/toolkit/mozapps/handling/src/nsContentDispatchChooser.js,v  <--  nsContentDispatchChooser.js
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/mozapps/handling/content/dialog.js;
/cvsroot/mozilla/toolkit/mozapps/handling/content/dialog.js,v  <--  dialog.js
new revision: 1.11; previous revision: 1.10
done