Closed Bug 400540 Opened 17 years ago Closed 16 years ago

Check installer removed-files against dist/bin

Categories

(Calendar :: Sunbird Only, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: ause)

Details

Attachments

(3 files, 1 obsolete file)

Follow-up from bug 400407: We need some scripting to check whether any file of installer/removed-files.in has been built into dist/bin. If that's not feasible within the build, then the script should at least be part of ause's release scripting collection.
Blocking 0.8 since we want to avoid further trouble when releasing 0.8.
Flags: blocking-calendar0.8+
calendar/installer/Makefile.in looks like the place to be
Assigning to Ause per Daniel's order.
Assignee: nobody → ause
works fine in a windows build on trunk

in a linux build on branch there is still one file to clearify:
-------------

ERROR: files found that are listed in "removed-files" but exist in "../../dist/sunbird":
 ../../dist/sunbird/components/autocomplete.xpt

-------------
Since packages-static has that file, it doesn't make sense to have it in removed-files.in, right?
Attachment #299743 - Flags: review?(ssitter)
Attachment #298953 - Flags: review?(daniel.boelzle)
Attachment #298954 - Flags: review?(daniel.boelzle)
Comment on attachment 299743 [details] [diff] [review]
remove components/autocomplete.xpt from removed-files.in

I'm not sure if we need to remove it. We don't ship autocomplete.xpt file on Windows. All the xpt. files listed in packages-static are linked together in one calendar.xpt file that is shipped.

The first appearance of autocomplete.xpt in removed-files.in only effects Windows and removes the no longer shipped files from the old installer. This should be OK to keep.

The second appearance of autocomplete.xpt in removed-files.in effects all system except Mac OS X. Firefox and Thunderbird also list the file:
http://lxr.mozilla.org/mozilla1.8/source/browser/installer/removed-files.in#45
http://lxr.mozilla.org/mozilla1.8/source/mail/installer/removed-files.in#50

Does Sunbird on Linux fails after using the update mechanism? The update 0.5 -> 0.7 used the same logic regarding autocomplete.xpt.
for the simple minded me, it's rather the question "do we need to ship it?". if not, it needs to be in the removed-files list. if we need to ship it, the entry has to be removed...
(In reply to comment #8)
> (From update of attachment 299743 [details] [diff] [review])
> I'm not sure if we need to remove it. We don't ship autocomplete.xpt file on
> Windows. All the xpt. files listed in packages-static are linked together in
> one calendar.xpt file that is shipped.
If autocomplete.xpt is obsolete (because merged into calendar.xpt), why is it packages-static then?

> The first appearance of autocomplete.xpt in removed-files.in only effects
> Windows and removes the no longer shipped files from the old installer. This
> should be OK to keep.
> 
> The second appearance of autocomplete.xpt in removed-files.in effects all
> system except Mac OS X. Firefox and Thunderbird also list the file:
> http://lxr.mozilla.org/mozilla1.8/source/browser/installer/removed-files.in#45
> http://lxr.mozilla.org/mozilla1.8/source/mail/installer/removed-files.in#50
So if we keep the latter line (the ifndef Mac part), then the first line (Windows only) is obsolete, right?
Comment on attachment 298954 [details] [diff] [review]
call script to check removed-files list

>+make-package : removed-files-checked
>+
>+removed-files-checked : removed-files stage-package
>+	$(PERL) $(srcdir)/check-remove-files.pl removed-files $(DIST)/$(MOZ_PKG_APPNAME)
>+

being curious: why did you add a dummy target "removed-files-checked"?
Comment on attachment 298953 [details]
check existance of files mentioned in the remove list

># The Original Code is Mozilla Communicator client code, released
># March 31, 1998.
>#
># The Initial Developer of the Original Code is
># Netscape Communications Corporation.
># Portions created by the Initial Developer are Copyright (C) 1998-1999
># the Initial Developer. All Rights Reserved.
>#
># Contributor(s):
>#   Sean Su <ssu@netscape.com>
I assume it should read "Sun Microsystems code etc. 2008..."
(In reply to comment #11)
> (From update of attachment 298954 [details] [diff] [review])
> >+make-package : removed-files-checked
> >+
> >+removed-files-checked : removed-files stage-package
> >+	$(PERL) $(srcdir)/check-remove-files.pl removed-files $(DIST)/$(MOZ_PKG_APPNAME)
> >+
> 
> being curious: why did you add a dummy target "removed-files-checked"?
> 
i need an own target to get between the execution of "make-package" and "stage-package", which seemed to be the right place to me.
since i those two aren't "file bound" targets anyway, i didn't bother to write some kind of "flag file".
does this answer your question?

(In reply to comment #12)
> (From update of attachment 298953 [details])
> ># The Original Code is Mozilla Communicator client code, released
> ># March 31, 1998.
> >#
> ># The Initial Developer of the Original Code is
> ># Netscape Communications Corporation.
> ># Portions created by the Initial Developer are Copyright (C) 1998-1999
> ># the Initial Developer. All Rights Reserved.
> >#
> ># Contributor(s):
> >#   Sean Su <ssu@netscape.com>
> I assume it should read "Sun Microsystems code etc. 2008..."
> 

ouch... too much copy&paste. thought it would be a good idea to have a license block at all. will look for something better.
Comment on attachment 298953 [details]
check existance of files mentioned in the remove list

r=dbo with license header changed
Attachment #298953 - Flags: review?(daniel.boelzle) → review+
Comment on attachment 298954 [details] [diff] [review]
call script to check removed-files list

r=dbo, however autocomplete.xpt part still needs to be resolved
Attachment #298954 - Flags: review?(daniel.boelzle) → review+
Status: NEW → ASSIGNED
Comment on attachment 299743 [details] [diff] [review]
remove components/autocomplete.xpt from removed-files.in

r- based on previous comments and ongoing discussion.

I'm not really sure how to handle autocomplete.xpt. Firefox has it in packages-static and in removed-files.in. Thunderbird only in removed-files.in. My suggestion would be to stick with the current solution as it worked for 0.5 and 0.7. Or ask someone with enough toolkit knowledge.
Attachment #299743 - Flags: review?(ssitter) → review-
@ause: So this needs special casing in your scripts then, at least for now.
Attachment #298953 - Attachment is obsolete: true
Attachment #302837 - Flags: review?(daniel.boelzle)
Comment on attachment 302837 [details] [diff] [review]
better license header, exception list

r=dbo with the Copyright being 2008
Attachment #302837 - Flags: review?(daniel.boelzle) → review+
committed to trunk and branch
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Attachment #302837 - Attachment is patch: true
Attachment #302837 - Attachment mime type: application/x-perl → text/plain
I discussed this issue with ause, how to verify this bug. This is a build issue, no change for testing/verifying. To remove this issue from the list I mark it 'VERIFIED'.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.