400635 - Check failed at test_dbservice.js: missing a colon

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Alex Vincent [:WeirdAl]]

Attachment: test output

*** CHECK FAILED:
testing-malware-simple;a:1
testing-phish-simple;a:2:s:3 ==
testing-malware-simple;a:1
testing-phish-simple;a:2s:3
JS frame :: /home/ajvincent/uranium/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: /home/ajvincent/uranium/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 114
JS frame :: ../../../../_tests/xpcshell-simple/test_url-classifier/unit/test_dbservice.js :: tablesCallback :: line 60

Between the 2 and the s, a colon is present in one and missing in the other.

Comment 1

[Alex Vincent [:WeirdAl]]

Reassigning to dcamp for diagnosis.

Comment 2

[Dave Camp (:dcamp)]

Attachment: fix test

The request format was changed in 397434, this patch updates the test.

Comment 3

[Alex Vincent [:WeirdAl]]

dcamp:  Would you please check this in?  Tests are exempt from the approvals requirement.

Comment 4

[Dave Camp (:dcamp)]

Checking in test_dbservice.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_dbservice.js,v  <--  test_dbservice.js
new revision: 1.5; previous revision: 1.4
done