User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; el-GR; rv:18.104.22.168) Gecko/20071008 Firefox/22.214.171.124 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; el-GR; rv:126.96.36.199) Gecko/20071008 Firefox/188.8.131.52 Allthough there is a localized string for "Credits" in all languages (footer_credits string, messages.po file), AMO uses the english word for all valid and supported locales as a page title. Reproducible: Always Steps to Reproduce: 1. 2. 3. Expected Results: The page title should use the localized string instead.
This applies to all page views (that's appversions, credits, submissionhelp etc.) because as you can see in site/app/controllers/pages_controller.php:61 it uses a generic display function to set the title to the pagename with the first letter capitalized (so there's no localization at all). site/app/controllers/pages_controller.php:86 $title = ucfirst($path[$count - 1]); Maybe something like using the pagename as part of the msgid would be a good workaround (credits_pagetitle, appversions_pagetitle etc.)? Would have to update all of the po files too.
I'll fix it for the 4.0.3 milestone. Will probably make a switch statement for the page title, defaulting to the current behavior.
Created attachment 346289 [details] [diff] [review] Possibility to localize page titles, incl. titles for the existing pages
Comment on attachment 346289 [details] [diff] [review] Possibility to localize page titles, incl. titles for the existing pages I'd rather have the title in the .thtml files somehow but I can't think of a clean way to do it. Them's the breaks I guess.
Fred: ok to verify this as fixed since it was used to fix bug 462481, right?
Yes, since that bug was verifiable, this one is fixed by definition too. :)
Thanks Fred; verified fixed.
Has been pushed live last night.