400684 - multi-message selection: mark as read timer not cleared

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Bruno 'Aqualon' Escherl]

The issue that was fixed for Thunderbird in bug 233027 should also be fixed in SeaMonkey.

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: Port of the TB patch

Comment 2

[Bruno 'Aqualon' Escherl]

Attachment: Port including all files

Forgot to include mailCommands.js in v1 of the patch.

Comment 3

[Karsten Düsterloh]

Comment on attachment 285736 [details] [diff] [review]
Port including all files

I noticed that I was (unreproducibly :( ) able several times to select multiple messages while one message was still shown in the messagepane, in which case the firing timer still marked all selected messages as read. I don't think it's a problem with the marking code here, but rather a timing issue in the selection stuff...

That said, just some minor nits:

>Index: mailnews/base/resources/content/mailWindowOverlay.js
>===================================================================
>     if (gMarkViewedMessageAsReadTimer)
>     {
>       MarkCurrentMessageAsRead();
>-      ClearPendingReadTimer();
>     }
> 
>     SetNextMessageAfterDelete();
>     if (reallyDelete) {
>         gDBView.doCommand(nsMsgViewCommandType.deleteNoTrash);
>     }
>     else {
>         gDBView.doCommand(nsMsgViewCommandType.deleteMsg);

The braces are not needed anymore.

>       if (markReadOnADelay && wintype == "mail:3pane") // only use the timer if viewing using the 3-pane preview pane and the user has set the pref
>+      {
>+        ClearPendingReadTimer();
>         gMarkViewedMessageAsReadTimer = setTimeout(MarkCurrentMessageAsRead, gPrefBranch.getIntPref("mailnews.mark_message_read.delay.interval") * 1000);
>+      }
>       else
>         MarkCurrentMessageAsRead();

If an if branch is braced, the else branch should be, too.


r=me

Landed on trunk with braces corrected.