400892 - Saving form passwords broken when info bars are not available.

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I'm currently trying to integrate toolkit's password manager with SeaMonkey. SeaMonkey doesn't currently have an information bar like Firefox, and the way the password manager code is written, it seems to allow for this case.

When I go to addons.mozilla.org, for example, enter my details and then select to remember password, I get this message repeated twice on the console:

Error: login has no properties
Source File: file:///mozilla/master/mozilla/sm/dist/bin/components/nsLoginManager.js
Line: 343

Tracking it down, nsLoginManagerPrompter.js in _showSaveLoginDialog is calling addLogin with "aLogin.formLogin". This property does not exist, it should just be "aLogin" (see http://mxr.mozilla.org/seamonkey/search?string=formLogin&find=&findi=&filter=&tree=seamonkey for example).

Patch attached.

I don't know how to do a unit/mochitest for this as the prompt code requires dialogs to be displayed and I've not yet worked out how to hook into a dialog after its displayed (and setTimeout doesn't seem to work for mochitests/modal dialogs either). So if you want me to do a test, I'll need some suggestions for it.

Comment 1

[Justin Dolske [:Dolske]]

Comment on attachment 285927 [details] [diff] [review]
The fix

Yeah, this was a trivial typo. We don't have a good way to poke at dialogs yet, so I don't think there's any point in trying to create an automated test here.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 285927 [details] [diff] [review]
The fix

Requesting approval for M9. Low risk patch that fixes typo.

I'm not sure if there's any place where FF would hit this, possibly authenticated RSS feeds I suppose, but extensions/other xul based apps will need this if they don't supply info bars.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 285927 [details] [diff] [review]
The fix

a=endgame drivers for M9

Comment 4

[Mark Banner (:standard8)]

Patch checked in -> fixed