Closed
Bug 400945
Opened 17 years ago
Closed 17 years ago
DTDParser for compare-locales not standards-compliant enough
Categories
(Mozilla Localizations :: Infrastructure, defect)
Mozilla Localizations
Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Unassigned)
References
()
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I came across yet another instance where the regexps we're using to parse l10n files for compare locales weren't good enough.
This time, I just bit the bullet and copied the allowed chars for DTD names over from the XML spec, at least to the extent that python's unicode like them.
Without this fix, http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/global/wizard.dtd goes totally unchecked. I bet there are other entities surfing beneath our radar right now, too.
Attachment #285999 -
Flags: review?(benjamin)
|
||
Updated•17 years ago
|
Attachment #285999 -
Flags: review?(benjamin) → review+
|
Reporter | |
Comment 1•17 years ago
|
||
Checked in on trunk, thanks for the review.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•16 years ago
|
Component: Testing → Infrastructure
Product: Core → Mozilla Localizations
QA Contact: testing → infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•