Closed
Bug 400949
Opened 16 years ago
Closed 16 years ago
Build Lightning with Sunbird
Categories
(Calendar :: Build Config, enhancement)
Calendar
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: dbo, Assigned: dbo)
References
()
Details
(Keywords: fixed1.8.1.12)
Attachments
(4 files, 3 obsolete files)
1.03 KB,
patch
|
mvl
:
review+
|
Details | Diff | Splinter Review |
1.80 KB,
patch
|
mvl
:
review+
benjamin
:
review+
dveditz
:
approval1.8.1.12+
|
Details | Diff | Splinter Review |
4.32 KB,
patch
|
mvl
:
review+
|
Details | Diff | Splinter Review |
1017 bytes,
patch
|
mvl
:
review+
|
Details | Diff | Splinter Review |
Although building lightning with sunbird per --enable-extension works well for me, it seems not to be the way how we build lightning in the tinderboxen: lightning's mozconfigs are based on thunderbird. Grepping thru the calendar tree for MOZ_SUNBIRD, it shows we've some places where we distinct lightning from sunbird by build variable (not dynamically). MOZ_SUNBIRD: 8:#ifdef MOZ_SUNBIRD ./locales/jar.mn 64:ifdef MOZ_SUNBIRD ./locales/Makefile.in 185:RCFLAGS += -DMOZ_SUNBIRD -I$(srcdir) 187:RCFLAGS += -DMOZ_SUNBIRD --include-dir $(srcdir) 203:RCFLAGS += -DMOZ_SUNBIRD ./sunbird/app/Makefile.in This bug should clarify what's missing to safely build lightning with sunbird.
Assignee | ||
Updated•16 years ago
|
Assignee | ||
Comment 1•16 years ago
|
||
some links: branch: <http://mxr.mozilla.org/mozilla1.8/search?string=MOZ_SUNBIRD&find=calendar&findi=&filter=&tree=mozilla1.8> trunk: <http://mxr.mozilla.org/seamonkey/search?string=MOZ_SUNBIRD&find=mozilla%2Fcalendar&findi=&filter=&tree=seamonkey> IMO this goal is feasible if we link calendar base components as a shared lib only (and let sunbird package that up rather than link calbscmp_s statically). However, this seems to be only possible on trunk.
Assignee | ||
Comment 2•16 years ago
|
||
Assignee: nobody → daniel.boelzle
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•16 years ago
|
||
Assignee | ||
Comment 4•16 years ago
|
||
Attachment #292034 -
Attachment is obsolete: true
Attachment #292035 -
Attachment is obsolete: true
Assignee | ||
Comment 5•16 years ago
|
||
Assignee | ||
Comment 6•16 years ago
|
||
These three patches build and package calbscmp and webdav as shared library on both branch and trunk.
Comment 7•16 years ago
|
||
Comment on attachment 292078 [details] [diff] [review] [trunk] make webdav use static CRT on windows >Index: mozilla/extensions/webdav/src/Makefile.in >-#EXPORT_LIBRARY = 0 I would prefer to leave some comment that mentions that EXPORT_LIBRARY is explicitly not set. Otherwise, it might looks like it was forgotten or something, and somebody might try to put it back. Also, a comment leaves a better cvs blame.
Comment 8•16 years ago
|
||
I tried the two trunk patches on mac. For non-static build, it seems to work (although i didn't try a clobber build yet). For static (as tinderboxes currently do), I get an error when linking libcalbasecomps: /usr/bin/ld: calDateTime.o has local relocation entries in non-writable section (__TEXT,__text) Not sure what that means though.
Assignee | ||
Comment 9•16 years ago
|
||
and FORCE_USE_PIC = 1
Attachment #292080 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Attachment #292078 -
Flags: review?(mvl)
Assignee | ||
Updated•16 years ago
|
Attachment #292079 -
Flags: review?(mvl)
Assignee | ||
Updated•16 years ago
|
Attachment #292417 -
Flags: review?(mvl)
Comment 10•16 years ago
|
||
latest patch works fine on linux trunk.
Comment 11•16 years ago
|
||
Comment on attachment 292078 [details] [diff] [review] [trunk] make webdav use static CRT on windows r=mvl with the change from comment 7
Attachment #292078 -
Flags: review?(mvl) → review+
Comment 12•16 years ago
|
||
Comment on attachment 292079 [details] [diff] [review] [branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical r=mvl with the same comment 7.
Attachment #292079 -
Flags: review?(mvl) → review+
Comment 13•16 years ago
|
||
Comment on attachment 292417 [details] [diff] [review] [branch+trunk] build calbscmp as shared lib, correct packages-static r=mvl, although I didn't test it yet.
Attachment #292417 -
Flags: review?(mvl) → review+
Assignee | ||
Comment 14•16 years ago
|
||
Comment on attachment 292079 [details] [diff] [review] [branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical mozilla/config part needs additional review and branch approval
Attachment #292079 -
Flags: review?(benjamin)
Attachment #292079 -
Flags: approval1.8.1.12?
Assignee | ||
Comment 15•16 years ago
|
||
Required for static branch builds sunbird+lightning. We aren't supporting Thunderbird 1.5 any longer, so there's no need anymore to package storage.
Attachment #294184 -
Flags: review?(mvl)
Comment 16•16 years ago
|
||
Comment on attachment 294184 [details] [diff] [review] [lightning] don't package storage any longer r=mvl
Attachment #294184 -
Flags: review?(mvl) → review+
Updated•16 years ago
|
Attachment #292079 -
Flags: review?(benjamin) → review+
Comment 17•16 years ago
|
||
Comment on attachment 292079 [details] [diff] [review] [branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #292079 -
Flags: approval1.8.1.12? → approval1.8.1.12+
Assignee | ||
Comment 18•16 years ago
|
||
All patches checked in => FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → 0.8
Updated•16 years ago
|
Keywords: fixed1.8.1.12
Assignee | ||
Comment 19•16 years ago
|
||
verified this works; calendar base components as well as webdav come as shared lib
Status: RESOLVED → VERIFIED
Comment 20•16 years ago
|
||
could be a nice occasion to consolidate tinderbox jobs/configs - after 0.8 of cause...
You need to log in
before you can comment on or make changes to this bug.
Description
•