400949 - Build Lightning with Sunbird

Status: VERIFIED FIXED

(Calendar :: Build Config, enhancement)

Description

[Daniel Boelzle [:dbo]]

Although building lightning with sunbird per --enable-extension works well for me, it seems not to be the way how we build lightning in the tinderboxen: lightning's mozconfigs are based on thunderbird.
Grepping thru the calendar tree for MOZ_SUNBIRD, it shows we've some places where we distinct lightning from sunbird by build variable (not dynamically).

MOZ_SUNBIRD:
8:#ifdef MOZ_SUNBIRD
./locales/jar.mn
64:ifdef MOZ_SUNBIRD
./locales/Makefile.in
185:RCFLAGS += -DMOZ_SUNBIRD -I$(srcdir)
187:RCFLAGS += -DMOZ_SUNBIRD --include-dir $(srcdir)
203:RCFLAGS += -DMOZ_SUNBIRD
./sunbird/app/Makefile.in

This bug should clarify what's missing to safely build lightning with sunbird.

Comment 1

[Daniel Boelzle [:dbo]]

some links:

branch:
<http://mxr.mozilla.org/mozilla1.8/search?string=MOZ_SUNBIRD&find=calendar&findi=&filter=&tree=mozilla1.8>

trunk:
<http://mxr.mozilla.org/seamonkey/search?string=MOZ_SUNBIRD&find=mozilla%2Fcalendar&findi=&filter=&tree=seamonkey>


IMO this goal is feasible if we link calendar base components as a shared lib only (and let sunbird package that up rather than link calbscmp_s statically).
However, this seems to be only possible on trunk.

Comment 2

[Daniel Boelzle [:dbo]]

Attachment: work in progress -- trunk

Comment 3

[Daniel Boelzle [:dbo]]

Attachment: work in progress -- branch

Comment 4

[Daniel Boelzle [:dbo]]

Attachment: [trunk] make webdav use static CRT on windows

Comment 5

[Daniel Boelzle [:dbo]]

Attachment: [branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical

Comment 6

[Daniel Boelzle [:dbo]]

Attachment: [branch+trunk] build calbscmp as shared lib, correct packages-static

These three patches build and package calbscmp and webdav as shared library on both branch and trunk.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 292078 [details] [diff] [review]
[trunk] make webdav use static CRT on windows

>Index: mozilla/extensions/webdav/src/Makefile.in
>-#EXPORT_LIBRARY  = 0

I would prefer to leave some comment that mentions that EXPORT_LIBRARY is explicitly not set. Otherwise, it might looks like it was forgotten or something, and somebody might try to put it back.
Also, a comment leaves a better cvs blame.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

I tried the two trunk patches on mac. For non-static build, it seems to work (although i didn't try a clobber build yet).
For static (as tinderboxes currently do), I get an error when linking libcalbasecomps:
/usr/bin/ld: calDateTime.o has local relocation entries in non-writable section (__TEXT,__text)
Not sure what that means though.

Comment 9

[Daniel Boelzle [:dbo]]

Attachment: [branch+trunk] build calbscmp as shared lib, correct packages-static

and FORCE_USE_PIC = 1

Comment 10

[ause]

latest patch works fine on linux trunk.

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 292078 [details] [diff] [review]
[trunk] make webdav use static CRT on windows

r=mvl with the change from comment 7

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 292079 [details] [diff] [review]
[branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical

r=mvl with the same comment 7.

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 292417 [details] [diff] [review]
[branch+trunk] build calbscmp as shared lib, correct packages-static

r=mvl, although I didn't test it yet.

Comment 14

[Daniel Boelzle [:dbo]]

Comment on attachment 292079 [details] [diff] [review]
[branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical

mozilla/config part needs additional review and branch approval

Comment 15

[Daniel Boelzle [:dbo]]

Attachment: [lightning] don't package storage any longer

Required for static branch builds sunbird+lightning. We aren't supporting Thunderbird 1.5 any longer, so there's no need anymore to package storage.

Comment 16

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 294184 [details] [diff] [review]
[lightning] don't package storage any longer

r=mvl

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 292079 [details] [diff] [review]
[branch] force webdav as shared lib, remove STATIC_EXTRA_LIBS for libical

approved for 1.8.1.12, a=dveditz for release-drivers

Comment 18

[Daniel Boelzle [:dbo]]

All patches checked in => FIXED

Comment 19

[Daniel Boelzle [:dbo]]

verified this works; calendar base components as well as webdav come as shared lib

Comment 20

[ause]

could be a nice occasion to consolidate tinderbox jobs/configs - after 0.8 of cause...