Closed Bug 400951 Opened 17 years ago Closed 17 years ago

Attribute calICalendar::suppressAlarms should be removed, be modeled as a calendar pref/property.

Categories

(Calendar :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: dbo)

References

Details

Attachments

(1 file)

Due to the fact that calICalendar::suppressAlarms is not used by any provider code and is only used from outside of the provider, there is no need to have an IDL attribute for it, i.e. making it mandatory to be implemented by provider developers. This information could be managed using a calendar pref/property.
This patch removes suppressAlarms from API, and prepares calAlarmService to act on pref changes, see bug 257428.
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #287847 - Flags: review?(philipp)
Blocks: 257428
Flags: wanted-calendar0.8+
Comment on attachment 287847 [details] [diff] [review]
removing from API, pref-based

>+        onPropertyDeleting: function(aCalendar, aName) {
>+            if (aName == "suppressAlarms") {
>+                this.onPropertyChanged(aCalendar, aName, null, aCalendar.getProperty(aName));
>+            }
>+        },
>     };
just spotted a js warning, will remove it.
Comment on attachment 287847 [details] [diff] [review]
removing from API, pref-based

Add a comment for suppressAlarms in the idl and get rid the warning as you mentioned.

r=philipp
Attachment #287847 - Flags: review?(philipp) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.