Closed
Bug 400999
Opened 17 years ago
Closed 17 years ago
mousing upwards over items in the history sidebar can leave "gaps" in the vertical lines
Categories
(Core :: XUL, defect, P3)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: moco, Assigned: enndeakin)
References
Details
Attachments
(3 files)
24.35 KB,
image/png
|
Details | |
1.63 KB,
application/vnd.mozilla.xul+xml
|
Details | |
2.90 KB,
patch
|
neil
:
review+
neil
:
superreview+
beltzner
:
approvalM9-
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
mousing upwards over items in the history sidebar can leave "gaps" in the vertical lines I'm seeing this with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102407 Minefield/3.0a9pre I'll attach a screen shot. see recently landed bugs #251910 and bug #364426
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Comment 2•17 years ago
|
||
note, if you force a repaint (by covering / revealing the window), the gaps go away.
Severity: normal → minor
Comment 4•17 years ago
|
||
I can reproduce the issue with a tag base tree, so this shouldn't be place specific. However, I don't see the issue with other trees like the certificate viewer one.
Comment 5•17 years ago
|
||
Regression range: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-08-23+04%3A00&maxdate=2007-08-24+04%3A00&cvsroot=%2Fcvsroot My guess would be bug 145320 (which blocked bug 251910)
Comment 6•17 years ago
|
||
A local backout of patch in bug 145320 fixes the issue
Blocks: 145320
Component: Places → Skinability
Product: Firefox → Core
QA Contact: places → skinability
Updated•17 years ago
|
Assignee: nobody → Jan.Varga
Component: Skinability → XP Toolkit/Widgets: Trees
QA Contact: skinability → xptoolkit.trees
Reporter | ||
Comment 7•17 years ago
|
||
sylvain, thanks for doing all that detective work! neil, do you think we could be missing an InvalidateRow() for the old row in nsTreeBodyFrame.cpp?
Assignee | ||
Comment 8•17 years ago
|
||
This is caused because the dirty rects are being compared to the cell rectangle after the padding/border has been excluded, yet the vertical lines are also drawn in this padding/border area, so the bit outside can get left out sometimes. This patch uses the row's area instead for the primary cell.
Assignee: Jan.Varga → enndeakin
Status: NEW → ASSIGNED
Attachment #286560 -
Flags: superreview?(neil)
Attachment #286560 -
Flags: review?(neil)
Updated•17 years ago
|
Attachment #286560 -
Flags: superreview?(neil)
Attachment #286560 -
Flags: superreview+
Attachment #286560 -
Flags: review?(neil)
Attachment #286560 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Attachment #286560 -
Flags: approvalM9?
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.9?
Comment 9•17 years ago
|
||
Comment on attachment 286560 [details] [diff] [review] use right height a=endgame drivers for after M9 freeze
Attachment #286560 -
Flags: approvalM9?
Attachment #286560 -
Flags: approvalM9-
Attachment #286560 -
Flags: approval1.9+
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.trees → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•