401054 - Add mozilla/security/tinderbox to the SecurityServices module definition

Status: RESOLVED FIXED

(mozilla.org :: CVS: Administration, task)

Description

[Nelson Bolyard (seldom reads bugmail)]

Attachment: proposed patch to CVS modules file

+++ This bug was initially created as a clone of Bug #377078 +++

In April, in bug 377078, we defined CVS modules named NSS, NSPR, JSS, and 
we defined a CVS module named SecurityServices, which is the union of the 
other 3 modules.

In bug 377080, we changed the Tinderbox page named "NSS" to report changes 
to any files in the SecurityServices module.  And it was added to the 
"Security" tree in bonsai, IIRC.  I seem to recall this involved changes to 
files whose contents are secret, not openly accessible through CVS.

Then the SecurityServices team did a bunch of enhancments to the Tinderbox 
scripts used for the NSS Tinderbox page (which is really the SecurityServices) 
tinderbox page. The newly modified NSS tinderbox scripts were checked in the 
new directory mozilla/security/tinderbox.  But that new directory was not 
itself added to the the definition of the SecurityServices module, so changes 
to the files in that directory do not show up in the NSS/SecurityServices tinderbox page.

We want to correct that.  

I think the mozilla/security/tinderbox directory needs to be added to 
the CVS SecurityServices module definition, and to whatever other secret 
files control the Tinderbox page and/or bonsai, and in despot.  
I can make the despot changes.  

A proposed patch for the module file change is attached.  I don't know what
needs to be changed for Tinderbox and/or bonsai.

Comment 1

[Dave Miller [:justdave]]

Tinderbox only cares that it matches a Bonsai tree.  Bonsai will pick it up automatically from the modules file change in CVS.  So this will be sufficient.

Comment 2

[Dave Miller [:justdave]]

Checking in modules;
/cvsroot/CVSROOT/modules,v  <--  modules
new revision: 1.246; previous revision: 1.245
done

Comment 3

[Dave Miller [:justdave]]

Just FYI, this will probably take a half hour or so to propagate, as Bonsai pulls from a local rsynced copy of cvs-mirror, which is in turn rsynced off cvs, etc.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Thanks very much for the quick turnaround. 
There's perhaps one more place that needs updating. 
It's the filter that determines what checkins get sent as emails to the
dev-tech-crypto-checkins mailing list via cvsmailfilter.

Comment 5

[Dave Miller [:justdave]]

mozilla/security is already included in that filter, so I think that includes mozilla/security/tinderbox