401105 - Indicate which theme is in use in update URL variable

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Justin Scott [:fligtar]]

With extensions, the extension's status (userEnabled, userDisabled, etc) is available in the update URL. Themes, however, all show as enabled.

It would be useful for theme authors (and AMO statistics for those authors) if themes that aren't in use were shown as disabled, or if calling them disabled is incorrect, making a new status for them to distinguish which is in use.

Comment 1

[Dave Townsend [:mossop]]

I think using the existing userEnabled/Disabled status makes sense for themes, shouldn't be too difficult to fix.

Comment 2

[Justin Scott [:fligtar]]

Requesting blocking-firefox3 - AMO would really like to make sure this is fixed for Firefox 3 and I can't request the "wanted" flag, nor do I know if that is approval for landing it.

I'm not sure how likely this is, but it would also be really helpful if this could be fixed in Firefox 2 as well. We'll have people still using Firefox 2 for a long time after Firefox 3 is released, and this is the sort of bug that leaves a permanent record in theme stats prior to being fixed. But, if not, Firefox 3 will be fine.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Marking wanted, for now.

Justin, what's the effect on AMO of not fixing this? If it severely impacts your ability to do something in your redesign, please explain and renominate.

(fwiw, marking wanted means that we're saying that we'd like a fix, but would ship without it; it also means you'll need to request approval1.9? on a reviewed patch before landing)

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This just adjust the userEnabled/Disabled status for themes. If they really are disabled (shouldn't be) then they will still be userDisabled. They will only appear as userEnabled though if the theme is selected as the current theme.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 293143 [details] [diff] [review]
patch rev 1

r=me... Thanks

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 293143 [details] [diff] [review]
patch rev 1

This is a simple change that allows AMO and other theme authors to gather more useful stats about whether their theme is actually in use or not.

Comment 7

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.270; previous revision: 1.269
done

Comment 8

[Dave Townsend [:mossop]]

AMO would like to see this on the branch, it is a very minor tweak which will vastly improve the stats that theme authors can get. I'll have to submit a new patch due to this code moving a bit but there is no real behavioural difference.

Comment 9

[Daniel Veditz [:dveditz]]

Not blocking a branch release, but if you get a reviewed branch patch and request approval we can look at it if it goes in early enough.

Comment 10

[Dave Townsend [:mossop]]

Attachment: ranch patch

Same patch for the branch

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 305478 [details] [diff] [review]
ranch patch

This allows people monitoring their update pings to actually get stats of whether their theme is in use. AMO in particular needs this for their stats to match up with those from trunk users.

Comment 12

[Samuel Sidler (old account; do not CC)]

Comment on attachment 305478 [details] [diff] [review]
ranch patch

Approved for 1.8.1.14. a=ss for release-drivers.

Comment 13

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.144.2.65; previous revision: 1.144.2.64
done

Comment 14

[juan becerra [:juanb]]

Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.15pre) Gecko/2008061004 BonEcho/2.0.0.15pre

Using livehttpheaders and checking for updates for the Scribblies theme.

The theme's status now indicates whether it is userEnabled or userDisabled if the theme is currently being used or not, contrasting with the way Firefox 2.0.0.14 would show the status as userEnabled all the time.