Bug 401140 (vc9-zlib)

VC9 issues building zlib

RESOLVED FIXED in mozilla1.9beta4

Status

RESOLVED FIXED
11 years ago
9 months ago

People

(Reporter: aaronlev, Assigned: sciguyryan)

Tracking

Trunk
mozilla1.9beta4
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
C:\run\vstudio9\VC\INCLUDE\stdio.h(358) : error C3163: '_vsnprintf': attributes inconsistent with previous declaration
        C:\run\vstudio9\VC\INCLUDE\stdio.h(350) : see declaration of '_vsnprintf'

Once you fix that, you still get:
LINK : fatal error LNK1117: syntax error in option 'MAPINFO:LINES'
(Reporter)

Comment 1

11 years ago
Created attachment 286191 [details] [diff] [review]
Hacks around the problem

I'm not sure what the actual correct fixes are, but this shows what I have to do to build.

Comment 2

11 years ago
We have just fixed the _vsnprintf issue for the zlib in NSS.
You can use the patch for zutil.h in bug 406258.
(Reporter)

Updated

11 years ago
Alias: vc9

Comment 3

11 years ago
The "vc9" alias belongs to the tracking bug for VC9. Changing to "vc9-zlib".
Alias: vc9 → vc9-zlib
(Reporter)

Comment 4

11 years ago
Bug 406258 is marked fixed, but after repulling I still had an issue with vsnprintf. Perhaps it wasn't checked in everywhere necessary. The zlib.h exists in mozilla/security and mozilla/modules/zlib

Also the MAPINFO issue still exists.
(Reporter)

Comment 5

11 years ago
I meant zutil.h
(Reporter)

Comment 6

11 years ago
Created attachment 291151 [details] [diff] [review]
Fixes the vsnprintf part of the problem

Not sure who should review this, nor what the fix to the MAPINFO issue is.

Comment 7

11 years ago
Comment on attachment 291151 [details] [diff] [review]
Fixes the vsnprintf part of the problem

r=wtc.

I'm sorry that I can't help you with the MAPINFO
issue because NSS doesn't use that linker flag.
Attachment #291151 - Flags: review+
(Reporter)

Updated

11 years ago
Attachment #291151 - Flags: approval1.9?

Updated

11 years ago
Attachment #291151 - Flags: approval1.9? → approval1.9+
(Reporter)

Comment 8

11 years ago
Checked in the _vsnprintf fix.

The MAPINFO issue still remains.
(Assignee)

Comment 9

11 years ago
Does anyone have any news on getting this fixed? Not that VS 2008 has been released for a while its possible more people will be using it and finding this little problem.
Per http://msdn2.microsoft.com/en-us/library/bha0yc3d(VS.80).aspx, MAPINFO:LINES actually went away in VC8, but the compiler must not have errored on it.  I guess we should just remove that flag completely.  Aaron: can you submit a patch that remove -MAPINFO:LINES from that rules.mk line, and r? me?  It would be nice to make sure that the trunk compiles in VC9 before we go into release mode, otherwise it's going to become painful to support the branch.  (VC6 on the 1.8 branch anyone?)
(Reporter)

Comment 11

11 years ago
Ted, I don't feel qualified to be on the hook for this. Can you work with someone on the build team?
Aaron: that's the whole point of review, isn't it?  I'm quite happy to review that patch, but I don't have VC9, so I'm not in a situation to test it.
(Reporter)

Comment 13

11 years ago
I'm willing to test a patch, if someone who understands the build system and all of our references to MAPINFO and MOZ_MAPINFO wants to make that. I'm sure it's not that hard, but I don't have cycles for it.
(Assignee)

Comment 14

11 years ago
Created attachment 301954 [details] [diff] [review]
Patch v1.0

Patch v1.0

Removed the flag and compiled under Visual Studio 2008 and ran the build with no problems. Not sure if this will need a sr too so I'll leave that to luser.
Assignee: nobody → sciguyryan
Status: NEW → ASSIGNED
Attachment #301954 - Flags: review?(ted.mielczarek)
Comment on attachment 301954 [details] [diff] [review]
Patch v1.0

Works for me.  Since this flag doesn't work in VC8, anything that's broken without it is already broken.
Attachment #301954 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

11 years ago
Attachment #301954 - Flags: approval1.9?
Comment on attachment 301954 [details] [diff] [review]
Patch v1.0

a1.9+=damons
Attachment #301954 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.585; previous revision: 3.584
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Version: unspecified → Trunk
Duplicate of this bug: 408254

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.