401140 - (vc9-zlib) VC9 issues building zlib

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Aaron Leventhal]

C:\run\vstudio9\VC\INCLUDE\stdio.h(358) : error C3163: '_vsnprintf': attributes inconsistent with previous declaration
        C:\run\vstudio9\VC\INCLUDE\stdio.h(350) : see declaration of '_vsnprintf'

Once you fix that, you still get:
LINK : fatal error LNK1117: syntax error in option 'MAPINFO:LINES'

Comment 1

[Aaron Leventhal]

Attachment: Hacks around the problem

I'm not sure what the actual correct fixes are, but this shows what I have to do to build.

Comment 2

[Wan-Teh Chang]

We have just fixed the _vsnprintf issue for the zlib in NSS.
You can use the patch for zutil.h in bug 406258.

Comment 3

[Gábor Stefanik]

The "vc9" alias belongs to the tracking bug for VC9. Changing to "vc9-zlib".

Comment 4

[Aaron Leventhal]

Bug 406258 is marked fixed, but after repulling I still had an issue with vsnprintf. Perhaps it wasn't checked in everywhere necessary. The zlib.h exists in mozilla/security and mozilla/modules/zlib

Also the MAPINFO issue still exists.

Comment 5

[Aaron Leventhal]

I meant zutil.h

Comment 6

[Aaron Leventhal]

Attachment: Fixes the vsnprintf part of the problem

Not sure who should review this, nor what the fix to the MAPINFO issue is.

Comment 7

[Wan-Teh Chang]

Comment on attachment 291151 [details] [diff] [review]
Fixes the vsnprintf part of the problem

r=wtc.

I'm sorry that I can't help you with the MAPINFO
issue because NSS doesn't use that linker flag.

Comment 8

[Aaron Leventhal]

Checked in the _vsnprintf fix.

The MAPINFO issue still remains.

Comment 9

[Ryan Jones-Ward [:sciguyryan]]

Does anyone have any news on getting this fixed? Not that VS 2008 has been released for a while its possible more people will be using it and finding this little problem.

Comment 10

[(not currently active) Ted Mielczarek]

Per http://msdn2.microsoft.com/en-us/library/bha0yc3d(VS.80).aspx, MAPINFO:LINES actually went away in VC8, but the compiler must not have errored on it.  I guess we should just remove that flag completely.  Aaron: can you submit a patch that remove -MAPINFO:LINES from that rules.mk line, and r? me?  It would be nice to make sure that the trunk compiles in VC9 before we go into release mode, otherwise it's going to become painful to support the branch.  (VC6 on the 1.8 branch anyone?)

Comment 11

[Aaron Leventhal]

Ted, I don't feel qualified to be on the hook for this. Can you work with someone on the build team?

Comment 12

[(not currently active) Ted Mielczarek]

Aaron: that's the whole point of review, isn't it?  I'm quite happy to review that patch, but I don't have VC9, so I'm not in a situation to test it.

Comment 13

[Aaron Leventhal]

I'm willing to test a patch, if someone who understands the build system and all of our references to MAPINFO and MOZ_MAPINFO wants to make that. I'm sure it's not that hard, but I don't have cycles for it.

Comment 14

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1.0

Patch v1.0

Removed the flag and compiled under Visual Studio 2008 and ran the build with no problems. Not sure if this will need a sr too so I'll leave that to luser.

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 301954 [details] [diff] [review]
Patch v1.0

Works for me.  Since this flag doesn't work in VC8, anything that's broken without it is already broken.

Comment 16

[Damon Sicore (:damons)]

Comment on attachment 301954 [details] [diff] [review]
Patch v1.0

a1.9+=damons

Comment 17

[Reed Loden [:reed]]

Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.585; previous revision: 3.584
done