401184 - BrowserContentView's performKeyEquivalent should call super

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Josh Aas]

Attachment: fix v1.0

While debugging bug 358379, I noticed that no widget nsChildView ever even sees native key equiv (e.g. command) events. That being the case, I though widgets couldn't possibly be responsible for bug 358379. Turns out they probably are responsible for it, but there is another problem before we even get there.

Instead of just returning "NO", BrowserContentView's performKeyEquivalent needs to return the value from it's super impl. That way it doesn't interrupt event flow and widget nsChildViews see the event.

Comment 1

[Stuart Morgan]

Comment on attachment 286233 [details] [diff] [review]
fix v1.0

Yep, I should have caught that in review. It's temporary code, but there's certainly no reason for it to be doing the wrong thing while it's there.

r/sr=smorgan

Comment 2

[Josh Aas]

landed on trunk