401211 - middleclick "Open All in Tabs" opens the bookmarks twice

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102522 Minefield/3.0a9pre ID:2007102522

repro:
open FF
open bookmarks menu
open a folder
middleclick on [Open All in Tabs]

result:
the bookmarks are opened twice

expected:
I'm not sure what to expect, probably same behavior as left-click

Comment 1

[Egor Pelevin]

Works in 20071024_1818_firefox-3.0a9pre.en-US.win32.zip
Fails in 20071024_1906_firefox-3.0a9pre.en-US.win32.zip 

Bonsai query:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1193275080&maxdate=1193277959

Regression from bug #399729

Comment 2

[Egor Pelevin]

Expected behaviour (https://bugzilla.mozilla.org/show_bug.cgi?id=175124#c29): 
Ctrl/Cmd+click on Open in Tabs appends the tabs and selects the first tab of
the set (foreground load)

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 286781 [details] [diff] [review]
patch

r=sspitzer (tested on windows xp as well)

Comment 5

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js 1.59

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007103100 Minefield/3.0a9pre ID:2007103100

VERIFIED

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv