401259 - Empty Places menu should read (empty) but on 2nd focus, sub-menus appears as tiny square

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007102605 Minefield/3.0a9pre ID:2007102605

Great summary I'm sure you'd agree ;-)

1. New profile, start firefox
2. Click on the Places bookmark folder on the bookmarks toolbar.
3. Move mouse pointer to one of the following menu items: Recently Visited Starred Pages, Most Visited Starred Pages, Recently Used Tags, Most Used Tags
4. Observe the first time you go to any of these menu items, the sub-menu reads something like (empty)
5. Hover over another menu item, then return to the menu item you hovered over in step 3.

Expected:
- Menu item reads (empty) again

Actual:
- Menu item appears empty, and as a tiny 3px by 3px box

Works: 20071024_1818_firefox-3.0a9pre.en-US.win32
Broken: 20071024_1906_firefox-3.0a9pre.en-US.win32

--> bug 399729

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 286397 [details] [diff] [review]
patch

r=sspitzer, thanks mano for the quick fix.

hopefully we can get this into m9.

Comment 3

[Asaf Romano (gone)]

mozilla/browser/components/places/content/toolbar.xml 1.109

Comment 4

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103004 Minefield/3.0a9pre. I verified following the STR in the original report and am not able to repro on either Win 2K or Mac.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv