Smart-folders are exposed in bookmark queries

VERIFIED FIXED in Firefox 3 beta1

Status

()

Firefox
Bookmarks & History
P2
normal
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

unspecified
Firefox 3 beta1
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [has patch][has reviews])

Attachments

(1 attachment)

2.24 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
beltzner
: approvalM9+
beltzner
: approval1.9+
Details | Diff | Splinter Review
Created attachment 286473 [details] [diff] [review]
patch

In the bookmarks-sidebar we do not set excludeQueries in its options (and shouldn't, we do want to expose queries in simple-folder view). As a result, searching there exposes query nodes. At least until we support "search for folders", this is hardly expected or useful.
Flags: blocking-firefox3?
Attachment #286473 - Flags: review?(sspitzer)
OS: Mac OS X → All
Priority: -- → P2
Hardware: PC → All
Comment on attachment 286473 [details] [diff] [review]
patch

r=sspitzer
Attachment #286473 - Flags: review?(sspitzer) → review+
Flags: blocking-firefox3? → blocking-firefox3+
Comment on attachment 286473 [details] [diff] [review]
patch

a=drivers for M9
Attachment #286473 - Flags: approvalM9?
Attachment #286473 - Flags: approvalM9+
Attachment #286473 - Flags: approval1.9+

Updated

10 years ago
Whiteboard: [has patch][has reviews]
mozilla/toolkit/components/places/src/nsNavHistory.cpp 1.179
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
QA could use some help with trying to verify this bug. Thanks.
Hi Marcia, here are the verification steps:

1. open bookmarks sidebar
2. search for "starred"
3. confirm that the "recently starred pages" smart folder is *not* in the results
verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9a9pre) Gecko/2007110204 Minefield/3.0a9pre. I verified using dietrich's steps in Comment 5 and compared to a 10-29 build which did not have the fix. Works like a charm.
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.