401514 - Don't use a getter when a property will do

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

...specifically, after the getter runs once and creates the value that it then always returns thereafter.  Note that a property with only a getter is read-only, hence the delete.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Do you intend to fix all of these patterns in the tree? See bug 385809.

Comment 2

[Jeff Walden [:Waldo]]

This was just something I ran across in passing; there's a little too much AST to really find this pattern everywhere in the tree, let alone fix all of them.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286520 [details] [diff] [review]
Patch

For consideration after beta4.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286520 [details] [diff] [review]
Patch

a1.9=beltzner

Comment 5

[Jeff Walden [:Waldo]]

In, with a tweak to accommodate the service changing from a var to a function -- was breaking Mochitests, actually, but I hadn't taken the time to figure out the problem -- did so before checkin.  :-)