Closed
Bug 401546
Opened 17 years ago
Closed 16 years ago
Alarm indicator icon is not visible for recurrent events
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: omar.bajraszewski, Assigned: Fallen)
References
Details
(Keywords: polish, Whiteboard: [good first bug])
Attachments
(1 file)
1.10 KB,
patch
|
dbo
:
review+
|
Details | Diff | Splinter Review |
Alarm indicator is only visible for non repeating events. It would be great to see the icon for repeating events too 1)Create an event repeating yearly and set alarm for it 2)There's no alarm icon for the event
Reporter | ||
Updated•17 years ago
|
Flags: wanted-calendar0.8?
With TB version 2.0.0.6 (20070728), Lightning 0.8pre (2007110803): If you edit the item by double click and select "All occurences" (btw: "edit item" in the context menu does not let you select this!), the alarm configured during creation of the event is correctly displayed in the field "Reminder". If you select "This occurence only", "Reminder" erroneously displays "No reminder", what at least goes with the missing alarm icon.
Assignee | ||
Comment 2•17 years ago
|
||
I probably didn't check the alarm setting of the parent item, just of the occurrence. This might be a candidate for a good first bug. When the event boxes are created (in the refresh function in calendar-multiday-view and calendar-month-view) the alarm icon is set up. There also the parent item should be checked for an alarmOffset. Note however that if the item is a recurrence exception that specifically has no alarm set, there should be no icon.
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [good first bug]
Comment 3•17 years ago
|
||
It would be good to have this in 0.8
Flags: wanted-calendar0.8? → wanted-calendar0.8+
Keywords: polish
Assignee | ||
Comment 4•16 years ago
|
||
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #297527 -
Flags: review?(daniel.boelzle)
Comment 5•16 years ago
|
||
Comment on attachment 297527 [details] [diff] [review] Show alarm indicator when parent has an alarm r=dbo
Attachment #297527 -
Flags: review?(daniel.boelzle) → review+
Assignee | ||
Comment 6•16 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Comment 7•16 years ago
|
||
I can verify that this fix works with the nightly build performed on the 18th. In addition I think the alarm indication icon should be at the end of the event. Right not there is some margin on the right side of the event bar. This results in truncating the name of the event too soon. If the alarm indication icon could be moved to the extreme right we can have more room left to display the event name. Thanks.
Comment 8•16 years ago
|
||
Marking VERIFIED per comment#7. parvata, the margin you see may be a category of the event without an assigned color.
Status: RESOLVED → VERIFIED
Comment 9•16 years ago
|
||
aahh... just discovered what that right margin is. Ok, thanks. But it would nice if the alarm icon utilizes the margin instead.
You need to log in
before you can comment on or make changes to this bug.
Description
•