401572 - Selective calling of onRemoveAlarmsByItem / Error Console "startDate has no Properties"

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

bug 288496 actually caused the error to appear, but the right place to fix it is in the alarm monitor.

onRemoveAlarmsByItem was called for most every item, even tasks that have no start and entry date. This patch changes it to only signal for items that have either start or entry date.

Comment 1

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Fix v1

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 286566 [details] [diff] [review]
Fix v1

>     removeAlarm: function cas_removeAlarm(aItem) {
>+        // If the item is a task and does not have a due or entry date, then we
>+        // can't fire an alarm for it. Such items should never be added so
>+        // removing them is trivial.
>+        if (!aItem.startDate && !aItem.entryDate) {
>+            return;
>+        }

Use hasAlarm(); r=dbo

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Fix v2

Second version as discussed. Asking for review again to make sure I did the right thing.

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Fix v3

New version as discussed:

* Put calculation into the renamed function getAlarmDate
* Only remove if it was possible to add the item
* Return from addAlarm if its not possible to add, which takes the load off the
  callers to check if the item should be added in the first place.

Comment 5

[Daniel Boelzle [:dbo]]

Comment on attachment 288318 [details] [diff] [review]
Fix v3

looks clean; r=dbo

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED