401601 - applications preference tab jumps the first time I select it

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

applications preference tab jumps the first time I select it

it appears to be resizing itself.

this was with today's mac os x trunk nightly.

Comment 1

[(not reading, please use [e-mail] instead)]

this was with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007102904 Minefield/3.0a9pre

Comment 2

[Robert Strong (they/them - no direct email)]

As a guess I think this may be due to the help button used on Mac OS X in the prefwindow

Comment 4

[Marcia Knous [:marcia]]

I see this on Leopard as well, using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9a9pre) Gecko/2007103104 Minefield/3.0a9pre. The best way to describe it is it seems like it "shudders" the first time it is selected.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is bad; the shuddering is there because the way that windows are resized on OSX is kinda broken right now -- see bug 402176 and bug 355177.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

We should just remove the resizing code until bug 355177 (blocker/P4) is fixed, IMO. I'm pretty sure that's what happened everywhere else.

Comment 7

[Robert Strong (they/them - no direct email)]

I am pretty sure that this is with animateFadeIn set to false

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yeah, it still jumps even with animateFadeIn is set to false -- it's a little weird even with my patch and animate set to true.  Something different is happening for that panel than all the others.

Comment 9

[Robert Strong (they/them - no direct email)]

I suspect this is in part cause by one of the patches to fix cutoff elements in prefpanes (e.g. bug 283697) along with the flex this prefpane uses.

Comment 10

[Robert Strong (they/them - no direct email)]

I've also seen some strange behavior with sizing most likely caused by the help button used on the Mac OS x prefwindow... it may be contributing to this and why it is only seen on Mac OS X.

Comment 11

[Robert Strong (they/them - no direct email)]

I have a couple of ideas of how this can be fixed so taking. If anyone wants to take this from me please feel free.

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - unhide help button before resizing

Comment 13

[(not reading, please use [e-mail] instead)]

Comment on attachment 290932 [details] [diff] [review]
patch rev1 - unhide help button before resizing

r=sspitzer.  I tested as well on mac os x.

robert points out that we could turn these 5 lines of code into one:

document.documentElement.getButton("help").hidden = !(aPaneElement.hasAttribute("helpURI"));

Comment 14

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.70; previous revision: 1.69
done

Comment 15

[Robert Strong (they/them - no direct email)]

Backing out for now due to tree being closed without any notice on the tinderboxen of the tree being closed... bleh

Comment 16

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.72; previous revision: 1.71
done

Comment 17

[Carsten Book [:Tomcat]]

verified fixed on trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007120404 Minefield/3.0b2pre