Closed
Bug 401668
Opened 17 years ago
Closed 17 years ago
calendar-unifinder.css changes text color in Thunderbird
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
0.8
People
(Reporter: mozilla, Assigned: mschroeder)
Details
Attachments
(2 files, 2 obsolete files)
9.20 KB,
image/gif
|
Details | |
13.08 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7 Build Identifier: Lightning 0.8pre 2007-10-29-05 calendar-unifinder.css changes the text color in Thunderbird when the text is in a tree (e.g. the text of the Sender and Subject in the message-list pane), and when the row is selected but is not focused. It does this because of the following code: treechildren::-moz-tree-cell-text(selected) { color: HighlightText; } Maybe that code is necessary in Sunbird but Lightning inherits the colors from Thunderbird so it seems that that code is (1) unnecessary in Lightning and (2) breaks one of Thunderbird's colors. Reproducible: Always Steps to Reproduce: 1) In WinXP, go to "Control Panel > Display properties". Switch to classic theme. Click on the "Appearance" tab. Click on the "Advanced" button. Click on the dropdown and choose "Selected Items". Change the first color to green (rgb(0,150,0)). Change the second color to white (rgb(255,255,255)). This gives you white text on a green background. 2) Restart Thunderbird 2.0.0.6. 3) Click on a message in the message-list pane. 4) Click on the message pane so that the message-list pane is not focused. Actual Results: The text color of the Sender/Subject/etc remains white. Expected Results: The text color of the Sender/Subject/etc should change to black. This is how it has always worked in Thunderbird (and in all of my other Windows programs) until I installed a recent nightly of Lightning. The problem is solved when I remove the code from calendar-unifinder.css.
Reporter | ||
Comment 1•17 years ago
|
||
Assignee | ||
Comment 2•17 years ago
|
||
Confirmed. Also the number of unread and all mails in the mail folder pane disappears when focused.
Severity: minor → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → mschroeder
Assignee | ||
Comment 3•17 years ago
|
||
Make the CSS rule for selected treechildren unifinder specific.
Attachment #286824 -
Flags: review?(philipp)
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 4•17 years ago
|
||
Comment on attachment 286824 [details] [diff] [review] Patch v1 > /* only format Unifinder lists */ > treechildren.unifinder-class::-moz-tree-row { > border-bottom: 1px dotted #AAA; > } > >-treechildren::-moz-tree-cell-text(selected) { >+#unifinder-search-results-listbox > treechildren::-moz-tree-cell-text(selected) { > color: HighlightText; > } Either use .unifinder-class as in the first rule here, or change all such rules to use #unifinder-search-results-listbox. I'd prefer the second option since our other trees also use the id in the selector I'd also like to rename that id to something that fits better. The tree is not a listbox. Something like #unifinder-tree for example. r- for now so we can discuss renaming the id. If we decide not to, r+ with the rule names aligned.
Attachment #286824 -
Flags: review?(philipp) → review-
Assignee | ||
Comment 5•17 years ago
|
||
(In reply to comment #4) > (From update of attachment 286824 [details] [diff] [review]) > [...] > I'd also like to rename that id to something that fits better. The tree is not > a listbox. Something like #unifinder-tree for example. > > r- for now so we can discuss renaming the id. If we decide not to, r+ with the > rule names aligned. I think we should leave the id alone. Maybe an extension uses it.
Assignee | ||
Comment 6•17 years ago
|
||
r+ for aligning rule names. Also removed unused class attribute. I hold off on checking the patch in until we have a decision regarding the id.
Attachment #286824 -
Attachment is obsolete: true
Attachment #287255 -
Flags: review+
Assignee | ||
Comment 7•17 years ago
|
||
* Renamed unifinder-search-results-listbox to unifinder-search-results-tree * Replaced gUnifinderTreeName with "unifinder-search-results-tree" * Removed unused method unifinderToDoHasFocus()
Attachment #287255 -
Attachment is obsolete: true
Attachment #287452 -
Flags: review?(philipp)
Comment 8•17 years ago
|
||
Comment on attachment 287452 [details] [diff] [review] Patch v3 Looks good, nothing to complain :) r=philipp
Attachment #287452 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 9•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
You need to log in
before you can comment on or make changes to this bug.
Description
•