40168 - Don't bring up the auto complete menu if we have an exact match

Status: VERIFIED WORKSFORME

(MailNews Core :: Composition, defect, P2)

Description

[Scott MacGregor]

During auto completion, if you type in an exact match and pause, we still bring
up the popup menu.

If we have an exact match, we should disable the popup so you don't get it.

(This came from phil peterson in a newsgroup posting.

Comment 1

[selmer (gone)]

It has become difficult to even enter an email address now that autocomplete is 
in but exact matches isn't working.  You must always take an explicit action to 
dismiss the popup showing the matches.  Nominating for dogfood.

Comment 2

[leger]

Putting on dogfood+ radar.

Comment 3

[Jean-Francois Ducarroz]

For some reason, the popup menu doesn't dismis by itself anymore when you press 
enter, it's a regression.

However, even if we have a exact match, I think we should display the popup menu 
as we cannot be sure at 100% that is what the user want. The right behavior is to 
autocomplete the user input with the exact match result and display the popup 
menu. If the user accept the match, he/she just need to press enter or tab. The 
memu should then goes away by itself.

Steve, can you see if somebody can take a look at the code to understand why the 
popup menu doesn't close anymore. It's in 
xpfe/components/autocomplete/resources/skin/autocomplete.xml

Comment 4

[scottputterman]

In my build from this morning, the popup is being dismissed on a tab and on an 
enter (at least on Windows).

We had talked about making it dogfood because of the fact that you had to click 
to make it go away.  Because this is no longer the case, I'd suggest this isn't 
dogfood anymore.  Does anyone disagree (or see different behavior than I'm 
seeing this morning).

As to whether or not we should bring up the autocomplete menu if we have an 
exact match, I'd also agree that we shouldn't bring it up on an exact match.  
But I don't think that is dogfood if the menu is easily dismissable.

Comment 5

[scottputterman]

I'm removing dogfood and dogfood+.  Please put back if you disagree.

Comment 6

[scottputterman]

moving to M18 and nominating for beta3.

Comment 7

[Jean-Francois Ducarroz]

I disagree with that, is not because I've typed an exact match that I should not 
see other possibilities. Imagine you have a card for "Jean" and "Jean-Francois" 
in your Addressbook and you type "Jean". It's an exact match but maybe what you 
really want is "Jean-Francois". Therefore the way Autocomplete works today is 
right and we should not change it. If nobody disagree, I will mark this bug as 
won't fix.

Comment 8

[scottputterman]

I'm not sure that's the problem.  I think the problem is that let's say you only
have Jean-Francois in your address book.  And you type in Jean. Well, you get a
popup with [e-mail] as well as [e-mail].  It would be
better in my opinion to just put in ducarroz and not have the popup.

Comment 9

[Jean-Francois Ducarroz]

But in this case (the one putterman just mentioned), your really want to address 
the message to [e-mail] and not jean-Francois <[e-mail]>, 
event if this address isn't part of your AB.

Comment 10

[scottputterman]

I've changed my opinion.  The autocomplete widget doesn't really get in the way.  
You can press enter without having to make a choice in it so it dismisses with 
the same amount of effort as if it hadn't appeared (since you'd have had to hit 
enter anyway).  The one caveat is that we would need to make tab dismiss it as 
well.  The user should never have to click to make a choice in this case.

Comment 11

[Jean-Francois Ducarroz]

I have already a bug for the tab issue I think!

Comment 12

[scottputterman]

Mail Triage is marking [nsbeta3-]

Comment 13

[pmock]

Changing qa assign to myself.

Comment 14

[jglick]

>[e-mail] 2000-05-24 09:34 wrote:
>In my build from this morning, the popup is being dismissed on a tab and on an 
>enter (at least on Windows).

This doesn't seem to be working in rtm. Nominate as mail3.

Comment 15

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8

Comment 16

[Jean-Francois Ducarroz]

Using today's build on both Mac and Windows, the popup menu is correctly
dismissed when the user either presst the Tab or enter key. You can also
dimisiss it with the escape key. Therefore Work for me...

Comment 17

[pmock]

Verified as worksforme on win32, linux, and macos using the following builds:
 win32 commercial seamonkey build 2001-012406-mtrunk installed on P500 Win98
 linux commercial seamonkey build 2001-012408-mtrunk installed on P200 RedHat 
6.2
 macos commercial seamonkey build 2001-011904-mtrunk installed on G3/400 OS 9.04

Verified that the tab, enter, and esc keys work as specified.