Closed
Bug 401704
Opened 17 years ago
Closed 17 years ago
Make Event dialog more extension friendly (be generous with id's)
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
56.97 KB,
patch
|
michael.buettner
:
review+
|
Details | Diff | Splinter Review |
Currently, the new event dialog is lacking a lot of ids to allow extension authors to easily overlay parts of it. There may be more that can be done, but right now I think we should give all: <row> <rows> <menu> <menupopup> <menuitem> <menuseparator> <statusbarpanel> elements an id. This way overlays can be controlled directly with id properties and insertbefore/insertafter. I don't know if there are any performance implications, but I believe this is the right step to encourage extension authors.
Flags: wanted-calendar0.8?
Assignee | ||
Comment 1•17 years ago
|
||
Adds lots of ids. I renamed a couple ids to align to the naming schema, but I left some in place not to too many things inside out.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #288720 -
Flags: review?(michael.buettner)
Comment 2•17 years ago
|
||
Comment on attachment 288720 [details] [diff] [review] Add ids to sun-calendar-event-dialog r=mickey.
Attachment #288720 -
Flags: review?(michael.buettner) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: wanted-calendar0.8?
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Comment 4•17 years ago
|
||
verified in latest nightly 20080114 -> task is fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•