Closed Bug 401727 Opened 17 years ago Closed 17 years ago

'dlgbuttons="accept,cancel">' at bottom of fonts.xul

Categories

(Thunderbird :: Preferences, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(1 file)

Attached patch fix fonts.xulSplinter Review
I noticed this when I was testing the thunderbird patch in bug 349437. Afaics it's been there for over 2 years. Wonder why it hasn't shown up before (no idea when it started to show up, though).
Attachment #286702 - Flags: review?(philringnalda)
Comment on attachment 286702 [details] [diff] [review]
fix fonts.xul

Haven't really seen philor for a while, so I'm bumping this to david instead. Btw, Neil told be that dbaron recently made text appear in xul, so that might be the reason for this.
Attachment #286702 - Flags: review?(philringnalda) → review?(hex226)
Comment on attachment 286702 [details] [diff] [review]
fix fonts.xul

ugh, damned bugzilla
Attachment #286702 - Flags: review?(hex226)
Comment on attachment 286702 [details] [diff] [review]
fix fonts.xul

David, please see previous comment.
Attachment #286702 - Flags: review?(bienvenu)
Comment on attachment 286702 [details] [diff] [review]
fix fonts.xul

ouch, thx for the patch.
Attachment #286702 - Flags: review?(bienvenu) → review+
That'll teach me to take 24 hours to think about something!

I was actually trying to decide between "follow Firefox in retaining this 'designed for screwups' style of closing an element in an ifdef," "fix ourselves at the cost of not staying in lockstep with Firefox" and "fix ourselves, and try to persuade Firefox to let us fix it, too." I'd pretty much decided on the third, but I guess we could do the first, too.
Comment on attachment 286702 [details] [diff] [review]
fix fonts.xul

Checking in mail/components/preferences/fonts.xul;
/cvsroot/mozilla/mail/components/preferences/fonts.xul,v  <--  fonts.xul
new revision: 1.12; previous revision: 1.11
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Sorry Phil, I thought you where off somewhere since I haven't seen you for a few days (missed your comment - was busy checking in) :-/ I should probably be a bit more patient in the future...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: