401731 - Modified Occurrence Shown twice in alarm dialog

Status: RESOLVED WORKSFORME

(Calendar :: Alarms, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

Steps

1. Create a recurring event
2. Modify the first occurrence to a different time
3. Set an alarm only on the modified occurrence

Actual:

* The Alarm dialog shows the occurrence twice.
* The occurrence is not dismissable (might be related to bug 368976)

Expected:

* Only one occurrence is shown
* The alarm should be dismissable

More Info:

This goes all the way down to calRecurrenceInfo's calculateDates() function. This is called from getOccurrence() It seems here that both the base items date and the first occurrences date is returned. Then getOccurrence calls getOccurrenceFor on all dates, which gets the occurrence exception for the first date twice.

I'm not sure if calculateDates needs fixing or getOccurrence.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Oops, found it.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

I guess I was too fast on that. Of course bug 389251 is the dismissable part, but the double occurrence part still stands.

Comment 3

[Simon Paquet [:sipaq]]

Not going to happen for 0.8.

Comment 4

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13pre) Gecko/2008020723 Calendar/0.8pre

I see a slightly different behavior now: After step 3 from comment #0 only one entry for the occurrence is shown in the new reminder dialog. But pressing "Dismiss" adds another entry for the occurrence to the dialog and the dialog is still shown. By pressing "Dismiss All" several times the entry count increases 1 > 2 > 4 > 8 > 16 > 32 ...

Comment 6

[Matthew Mecca [:mmecca]]

I'm not able to reproduce this - can anyone provide a more detailed case?

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Hmm I'm not able to reproduce this with my steps from comment 0 either, but I still do get this once in a while, and it looks like back in comment 0 I actually found out why, so lets keep this bug open for now. I'll try to find new STR.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

I've looked at the code, and it seems I've fixed this issue with bug 391495, back in the days. Specifically, the addition of occurrenceMap should be making sure that an occurrence is not returned twice.

I'm going to mark this bug as wfm, we can reopen if this issue shows up again.