401792 - Restore support for cygwin in all.sh

Status: RESOLVED FIXED

(NSS :: Test, defect, P3)

Description

[Julien Pierre]

all.sh was once made to work with cygwin shell. It is currently broken again on the trunk. One of the main reasons is that pwd is being invoked and the result is being passed to NSS tools that take native windows paths. The pwd output needs to be processed with cygpath.

Another reason is that the uname for cygwin is not being checked properly in all cases. On Windows 64-bit, cygwin's uname -s returns CYGWIN_NT-5.2-WOW64 .

Comment 1

[Julien Pierre]

Attachment: Process the output of pwd where needed . Auto-detect whether to use gmake.exe or make.exe .

Comment 2

[Alexei Volkov]

Comment on attachment 287783 [details] [diff] [review]
Process the output of pwd where needed . Auto-detect whether to use gmake.exe or make.exe .

Patch looks ok as far as it goes. Line that sets TESTDIR should have indentation. Also I think echos were use for debugging purposes and should be removed

Comment 3

[Julien Pierre]

Alexei,

Thanks for the review. Actually, that line already had indentation. You can check in the ASCII view of the patch. I don't know why diffzilla shows it without indentation. It's a bugzilla problem.
I will remove the echos. I found one more problem with cygwin with the dbtest -r case. I will attach a new patch.

Comment 4

[Julien Pierre]

Attachment: Insert cygpath calls

Comment 5

[Slavomir Katuscak]

Comment on attachment 288097 [details] [diff] [review]
Insert cygpath calls

Seems OK, but what's the reason of converting paths to mixed mode ? Is this only way how it works on Cygwin ?

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 288097 [details] [diff] [review]
Insert cygpath calls

This path had a wrong description.  It doesn't'  remove any echo commands.

Comment 7

[Julien Pierre]

Nelson,

Re: comment 6, the description of the patch was correct. The first patch had some extraneous echo debug statements that Alexei noticed in comment 2, and the second patch removed them.

Comment 8

[Julien Pierre]

Slavo, Alexei, thanks for the reviews. I checked this in to the trunk :

Checking in cert/cert.sh;
/cvsroot/mozilla/security/nss/tests/cert/cert.sh,v  <--  cert.sh
new revision: 1.48; previous revision: 1.47
done
Checking in cipher/performance.sh;
/cvsroot/mozilla/security/nss/tests/cipher/performance.sh,v  <--  performance.sh
new revision: 1.5; previous revision: 1.4
done
Checking in common/init.sh;
/cvsroot/mozilla/security/nss/tests/common/init.sh,v  <--  init.sh
new revision: 1.58; previous revision: 1.57
done
Checking in fips/fips.sh;
/cvsroot/mozilla/security/nss/tests/fips/fips.sh,v  <--  fips.sh
new revision: 1.31; previous revision: 1.30
done
Checking in iopr/cert_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/cert_iopr.sh,v  <--  cert_iopr.sh
new revision: 1.4; previous revision: 1.3
done

And to NSS_3_11_BRANCH :
Checking in cert/cert.sh;
/cvsroot/mozilla/security/nss/tests/cert/cert.sh,v  <--  cert.sh
new revision: 1.28.2.11; previous revision: 1.28.2.10
done
Checking in cipher/performance.sh;
/cvsroot/mozilla/security/nss/tests/cipher/performance.sh,v  <--  performance.sh
new revision: 1.3.10.1; previous revision: 1.3
done
Checking in common/init.sh;
/cvsroot/mozilla/security/nss/tests/common/init.sh,v  <--  init.sh
new revision: 1.40.24.11; previous revision: 1.40.24.10
done
Checking in fips/fips.sh;
/cvsroot/mozilla/security/nss/tests/fips/fips.sh,v  <--  fips.sh
new revision: 1.19.28.9; previous revision: 1.19.28.8
done
Checking in iopr/cert_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/cert_iopr.sh,v  <--  cert_iopr.sh
new revision: 1.2.2.3; previous revision: 1.2.2.2
done

Comment 9

[Julien Pierre]

Slavo,

Re: comment 5, this was the only way I could get things to work properly.