Closed Bug 401792 Opened 13 years ago Closed 13 years ago

Restore support for cygwin in all.sh

Categories

(NSS :: Test, defect, P3)

x86
Windows Server 2003
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.9

People

(Reporter: julien.pierre, Assigned: julien.pierre)

Details

Attachments

(1 file, 1 obsolete file)

all.sh was once made to work with cygwin shell. It is currently broken again on the trunk. One of the main reasons is that pwd is being invoked and the result is being passed to NSS tools that take native windows paths. The pwd output needs to be processed with cygpath.

Another reason is that the uname for cygwin is not being checked properly in all cases. On Windows 64-bit, cygwin's uname -s returns CYGWIN_NT-5.2-WOW64 .
Attachment #287783 - Flags: superreview?(alexei.volkov.bugs)
Attachment #287783 - Flags: review?(slavomir.katuscak)
Assignee: nobody → julien.pierre.boogz
Priority: -- → P3
Target Milestone: 3.12 → 3.11.9
Comment on attachment 287783 [details] [diff] [review]
Process the output of pwd where needed . Auto-detect whether to use gmake.exe or make.exe .

Patch looks ok as far as it goes. Line that sets TESTDIR should have indentation. Also I think echos were use for debugging purposes and should be removed
Attachment #287783 - Flags: superreview?(alexei.volkov.bugs) → superreview+
Alexei,

Thanks for the review. Actually, that line already had indentation. You can check in the ASCII view of the patch. I don't know why diffzilla shows it without indentation. It's a bugzilla problem.
I will remove the echos. I found one more problem with cygwin with the dbtest -r case. I will attach a new patch.
Attachment #287783 - Attachment is obsolete: true
Attachment #288097 - Flags: superreview?(slavomir.katuscak)
Attachment #288097 - Flags: review?(alexei.volkov.bugs)
Attachment #287783 - Flags: review?(slavomir.katuscak)
Comment on attachment 288097 [details] [diff] [review]
Insert cygpath calls

Seems OK, but what's the reason of converting paths to mixed mode ? Is this only way how it works on Cygwin ?
Attachment #288097 - Flags: superreview?(slavomir.katuscak) → superreview+
Comment on attachment 288097 [details] [diff] [review]
Insert cygpath calls

This path had a wrong description.  It doesn't'  remove any echo commands.
Attachment #288097 - Attachment description: Remove echo statements, fix dbtest → Insert cygpath calls
Nelson,

Re: comment 6, the description of the patch was correct. The first patch had some extraneous echo debug statements that Alexei noticed in comment 2, and the second patch removed them.
Attachment #288097 - Flags: review?(alexei.volkov.bugs) → review+
Slavo, Alexei, thanks for the reviews. I checked this in to the trunk :

Checking in cert/cert.sh;
/cvsroot/mozilla/security/nss/tests/cert/cert.sh,v  <--  cert.sh
new revision: 1.48; previous revision: 1.47
done
Checking in cipher/performance.sh;
/cvsroot/mozilla/security/nss/tests/cipher/performance.sh,v  <--  performance.sh
new revision: 1.5; previous revision: 1.4
done
Checking in common/init.sh;
/cvsroot/mozilla/security/nss/tests/common/init.sh,v  <--  init.sh
new revision: 1.58; previous revision: 1.57
done
Checking in fips/fips.sh;
/cvsroot/mozilla/security/nss/tests/fips/fips.sh,v  <--  fips.sh
new revision: 1.31; previous revision: 1.30
done
Checking in iopr/cert_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/cert_iopr.sh,v  <--  cert_iopr.sh
new revision: 1.4; previous revision: 1.3
done

And to NSS_3_11_BRANCH :
Checking in cert/cert.sh;
/cvsroot/mozilla/security/nss/tests/cert/cert.sh,v  <--  cert.sh
new revision: 1.28.2.11; previous revision: 1.28.2.10
done
Checking in cipher/performance.sh;
/cvsroot/mozilla/security/nss/tests/cipher/performance.sh,v  <--  performance.sh
new revision: 1.3.10.1; previous revision: 1.3
done
Checking in common/init.sh;
/cvsroot/mozilla/security/nss/tests/common/init.sh,v  <--  init.sh
new revision: 1.40.24.11; previous revision: 1.40.24.10
done
Checking in fips/fips.sh;
/cvsroot/mozilla/security/nss/tests/fips/fips.sh,v  <--  fips.sh
new revision: 1.19.28.9; previous revision: 1.19.28.8
done
Checking in iopr/cert_iopr.sh;
/cvsroot/mozilla/security/nss/tests/iopr/cert_iopr.sh,v  <--  cert_iopr.sh
new revision: 1.2.2.3; previous revision: 1.2.2.2
done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Slavo,

Re: comment 5, this was the only way I could get things to work properly.
You need to log in before you can comment on or make changes to this bug.