Correct comma splice in malware warning description

VERIFIED FIXED in Firefox 3 beta1

Status

()

Toolkit
Safe Browsing
VERIFIED FIXED
11 years ago
4 years ago

People

(Reporter: reed, Assigned: reed)

Tracking

({polish})

Trunk
Firefox 3 beta1
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 286766 [details] [diff] [review]
patch - v1

If one goes to "http://www.mozilla.com/firefox/its-an-attack.html", one will see:
"The web site at www.mozilla.com has been reported as an attack site, and has been blocked based on your security preferences."

The comma after "site" and before "and" should not be there.
Attachment #286766 - Flags: review?(beltzner)
Attachment #286766 - Flags: approvalM9?
Attachment #286766 - Flags: approval1.9?
Comment on attachment 286766 [details] [diff] [review]
patch - v1

r+uir+a=beltzner
Attachment #286766 - Flags: ui-review+
Attachment #286766 - Flags: review?(beltzner)
Attachment #286766 - Flags: review+
Attachment #286766 - Flags: approvalM9?
Attachment #286766 - Flags: approvalM9+
Attachment #286766 - Flags: approval1.9?
Attachment #286766 - Flags: approval1.9+
(Assignee)

Comment 2

11 years ago
Checking in browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties,v  <--  blockedSite.properties
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
http://owl.english.purdue.edu/owl/resource/598/02/

1. Join the two independent clauses with one of the coordinating conjunctions (and, but, for, or, nor, so, yet), and use a comma before the connecting word.

By _removing_ the very suggested comma(s), how did you fix this comma splice?
(Assignee)

Comment 4

11 years ago
"has been blocked based on your security preferences" is not an independent clause. For it to be an independent clause, it must have a subject, which it lacks.
reed++

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre)
Gecko/2008012304 Minefield/3.0b3pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008012304
Minefield/3.0b3pre

-and-

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012304
Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.