401907 - Running Help->Check for updates... leaks

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Running Help->Check for updates... leaks at least on non-official builds.
Some nsXULElements and various XBL objects, and things which those keep alive, are leaked.

Comment 1

[Carsten Book [:Tomcat]]

Attachment: leak log

steps to reproduce

Help -> Check for update
-> Leak

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

So the problem might that http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/update/content/updates.xml has #update twice and something in XBL doesn't
release things in that case.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 289868 [details] [diff] [review]
proposed patch

The reason to use the first ID (not last) is to be consistent with HTML's getElementById

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 289868 [details] [diff] [review]
proposed patch

Looks good, but can we please:

1)  Add a mochitest for this (actually testing that the first binding with that id is used).

2)  Get a bug filed on the XBL file in question.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(1)
Will add

(2)
Bug 405044 blocks this one.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: with mochitest

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 289904 [details] [diff] [review]
with mochitest

Fixing leak.
If this gets approved, also Bug 405044 needs to be approved.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 289904 [details] [diff] [review]
with mochitest

a=beltzner for drivers