autocomplete popup code, use the popup's open state directly

RESOLVED INACTIVE

Status

()

defect
RESOLVED INACTIVE
12 years ago
Last year

People

(Reporter: moco, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

autocomplete popup code, use the popup's open state directly

in bug #399664 comment #22, neil writes:

>+        <handlers>
>+          <handler event="popupshowing"><![CDATA[
>+        // If normalMaxRows wasn't already set by the input, then set it here
>+        // so that we restore the correct number when the popup is hidden.
>+        if (this._normalMaxRows < 0)
>+          this._normalMaxRows = this.mInput.maxRows;
>+
>+        this.mPopupOpen = true;
>+      ]]></handler>

"The popup won't necessarily be opened, for instance if another listener called  preventDefault. You should just get the popup's open state directly when needed
 via its 'state' property."

note, both the existing autocomplete tree based popup code and the upcoming richlistbox version has this problem
Component: General → Autocomplete
Product: Firefox → Toolkit
QA Contact: general → autocomplete
from gavin:

>+      <property name="overrideValue" readonly="true"
>+                onget="return null;"/>
>+
>+      <property name="popupOpen" readonly="true"
>+                onget="return this.mPopupOpen;"/>

make this use this.mPopup.popupState as Neil mentions in his comment.
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.