Closed
Bug 402038
Opened 17 years ago
Closed 16 years ago
Drop support for Thunderbird 1.5
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: ssitter, Unassigned)
References
()
Details
Attachments
(1 obsolete file)
Based on the responses to the Calendar Weblog post about this issue it seems clear that we should drop Lightning support for Thunderbird 1.5 to focus the development effort. I suggest the same for the Lightning in Firefox build. We should set em:minVersion to 2.0.0.0 and em:maxVersion to 2.0.0.* in mozilla/calendar/lightning/install.rdf mozilla/calendar/prototypes/wcap/wcap-enabler/install.rdf mozilla/calendar/prototypes/wcap/lightning-wcap/install.rdf
Updated•17 years ago
|
Assignee: nobody → bugzilla
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 1•17 years ago
|
||
I think this can wait until lightning really fails to work on tb1.5. Until then, what's the problem with leaving it enabled?
Comment 2•17 years ago
|
||
(In reply to comment #1) > I think this can wait until lightning really fails to work on tb1.5. Until > then, what's the problem with leaving it enabled? Since bug 372829 landed we already have a problem with Tb1.5. The unifinder is also visible in mail mode, not really convincing :-)
Comment 3•17 years ago
|
||
Oh, I missed that. (didn't see any comments in the bug either). Anyway, just ignore what I said. :)
Comment 4•17 years ago
|
||
(In reply to comment #2) > Since bug 372829 landed we already have a problem with Tb1.5. The unifinder is > also visible in mail mode, not really convincing :-) We won't spend further time in fixing that for 1.5 and drop support for 0.8.
Flags: wanted-calendar0.8+
Reporter | ||
Comment 5•17 years ago
|
||
Assignee: bugzilla → ssitter
Attachment #287454 -
Flags: review?(daniel.boelzle)
Comment 6•17 years ago
|
||
Comment on attachment 287454 [details] [diff] [review] [checked in] drop support for 1.5 r=dbo, thanks for the patch.
Attachment #287454 -
Flags: review?(daniel.boelzle) → review+
Comment 7•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Comment 8•17 years ago
|
||
I think this is only the first step... To go the whole way you should also remove or modify obsolete functions like > /** > * Helper function to get the view deck in a neutral way, regardless of whether > * we're in Thunderbird 1.x or 2.x > */ > function getMailBar() { > return document.getElementById("mail-bar2") || > document.getElementById("mail-bar"); > } On the other hand, this solutions leaves it to the user to re-enable Lighting for TB 1.5 and ignore the errors (i.e. bug 372829)...
Comment 9•17 years ago
|
||
I think we should get rid of such relicts. If we do not, then it will persist in the code, similar to the moz 1.7 tree view stuff that I came across a while ago. This should be done in a new bug though. Maybe this will be a [good first bug].
Comment 10•17 years ago
|
||
Yes, we should clean this stuff up; reoponing bug. Albeit this is nothing we need to focus on for 0.8; removing wanted-flag.
Status: RESOLVED → REOPENED
Flags: wanted-calendar0.8+
Resolution: FIXED → ---
Reporter | ||
Updated•17 years ago
|
Assignee: ssitter → nobody
Status: REOPENED → NEW
Summary: Drop Lightning support for Thunderbird 1.5 → Drop support for Thunderbird 1.5 and remove obsolete workarounds
Reporter | ||
Updated•17 years ago
|
Attachment #287454 -
Attachment description: drop support for 1.5 → [checked in] drop support for 1.5
Attachment #287454 -
Attachment is obsolete: true
Comment 11•16 years ago
|
||
I'm setting this bug to fixed, because I agree with Philipp in comment 9. Removing the TB1.5-specific code should take place in followup bugs. One of those already got fixed by Sebo (bug 430062). I just filed another one (bug 432218).
Status: NEW → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
Summary: Drop support for Thunderbird 1.5 and remove obsolete workarounds → Drop support for Thunderbird 1.5
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•