402056 - Anonymous article feedback should have titles defaulted to the name of the page

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Jason Barnabe (np)]

Default the title for anonymous feedback to the title of the article instead of "Was this article helpful?" That would make this page more useful:

http://support.mozilla.com/tiki-list_comments.php

Comment 1

[E. Cooper [:ecooper]]

Attachment: patch to adjust feedback title for anonymous users

Anonymous users will have their feedback titles defaulted to the article title. Registered users will be still using the "Untitled 00-00-00 00:00:00" format. Safe to assume that should be changed as well?

Comment 2

[David Tenser [:djst]]

(In reply to comment #1)
> Anonymous users will have their feedback titles defaulted to the article title.
> Registered users will be still using the "Untitled 00-00-00 00:00:00" format.
> Safe to assume that should be changed as well?

Yes, please change that as well. :)

Comment 3

[E. Cooper [:ecooper]]

Attachment: for bug 458874, bug 409642, bug 402056

Registered users now get article titles as titles.

Comment 4

[Nelson Ko [:nkoth]]

Comment on attachment 342121 [details] [diff] [review]
for bug 458874, bug 409642, bug 402056	 

patch duplicates attachment 342119 [details] [diff] [review], in r18929/r18930

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

In trying to test this, I've made anonymous comment to http://support-stage.mozilla.org/en-US/kb/Other+Firefox+support, but they haven't yet showed up on http://support-stage.mozilla.org/tiki-list_comments.php?login; anybody know why?

Comment 6

[Chris Ilias [:cilias]]

Didn't work for me either.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Nelson, can you take a look?

Comment 8

[E. Cooper [:ecooper]]

Attachment: Assigns default comment title in case page title isn't available (like on forums)

Noticed this was an issue when testing for the reported comments bug. It was a total "Duh" moment.

Comment 9

[Nelson Ko [:nkoth]]

Comment on attachment 342529 [details] [diff] [review]
Assigns default comment title in case page title isn't available (like on forums) 

Other than the extra spaces, I have committed this patch as is into r19031/r19032.

Comment 10

[Nelson Ko [:nkoth]]

I can't reproduce this on my development server. Eric, can you reproduce it?

The behavior on support-stage is strange. Important to note that this problem exists in production as well.

Even if you key in the wrong code, you get no error message...

You are supposed to get an error message saying that you keyed in the wrong code if you key in the wrong code...



(In reply to comment #5)
> In trying to test this, I've made anonymous comment to
> http://support-stage.mozilla.org/en-US/kb/Other+Firefox+support, but they
> haven't yet showed up on
> http://support-stage.mozilla.org/tiki-list_comments.php?login; anybody know
> why?

Comment 11

[E. Cooper [:ecooper]]

Nope. I tested this on my development box numerous times and everything is acting as it should. 

Are we sure support-stage is running the same code?

(In reply to comment #10)
> I can't reproduce this on my development server. Eric, can you reproduce it?
> 
> The behavior on support-stage is strange. Important to note that this problem
> exists in production as well.
> 
> Even if you key in the wrong code, you get no error message...
> 
> You are supposed to get an error message saying that you keyed in the wrong
> code if you key in the wrong code...
> 
> 
> 
> (In reply to comment #5)
> > In trying to test this, I've made anonymous comment to
> > http://support-stage.mozilla.org/en-US/kb/Other+Firefox+support, but they
> > haven't yet showed up on
> > http://support-stage.mozilla.org/tiki-list_comments.php?login; anybody know
> > why?

Comment 12

[Nelson Ko [:nkoth]]

It is hard to fix this when we can't reproduce it. Could it be due to session or something? Maybe something to do with the <form enctype="multipart/form-data" ? Or some caching/netscalar thing? I'm randomly tossing ideas here... Comment submission works when you are logged in fwiw (but it's not exactly the same thing).

Mark, any ideas (just wondering coz you may have seen this kind of behavior before...)? Is there a way to see exactly the POST request received by the server?

Comment 13

[E. Cooper [:ecooper]]

If someone with access to support-stage could attach the source of the feedback form, that might give us some hints. There are a few hidden inputs that could be getting funky data.

As anon, click the submit additional feedback link. Fully highlight the form (from "Your feedback[...]" past the captcha), right-click and choose view selection source. Seeing that might help...or it might not.I'm not quite sure what the problem is.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

http://support-stage.mozilla.org is open; "support/stage" is the username/password, respectively (set up this way to block Google from indexing the articles on staging).

Comment 15

[E. Cooper [:ecooper]]

The patch only changed the template, and it seems to be performing as it should be (all the hidden values match my dev server). Strange. 

Am I correct in assuming that tiki-list_comments.php still isn't displaying anon comments?

Comment 16

[E. Cooper [:ecooper]]

Well, some good news on this front...sort of. I just checked this again, and anon comments no longer work in my dev instance. Registered comments do, still. 

It's sort of great because it means a change external to the patch is causing this problem. I'm looking over the comments library now. Hopefully this should finally be wrapped up.

Comment 17

[E. Cooper [:ecooper]]

It looks like this is happening because the comments code isn't being loaded for anonymous users. Nelson, off the top of your head, do you know why this isn't happening?

All kb pages are processed through tiki-index.php, right?

Comment 18

[E. Cooper [:ecooper]]

Attachment: Processes comments even if page is cached

Turns out the problem was unrelated to the patch, and was introduced with the full-page buffering.

Anon comments weren't being processed because the cached page was being served before they could be processed.

Comment 19

[Nelson Ko [:nkoth]]

Comment on attachment 350101 [details] [diff] [review]
Processes comments even if page is cached

in r20265/r20266

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; comment 5 is now working just fine for me.

Comment 21

[Louis-Philippe Huberdeau]

For the sake of not putting in too many strange conditions, would simply hiding the title box for everyone do the trick?

Comment 22

[Louis-Philippe Huberdeau]

wiki_comments_notitle preference added.