Closed Bug 402081 Opened 12 years ago Closed 12 years ago

[fr] DOMi update due to bug 347792

Categories

(Mozilla Localizations :: fr / French, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cedric.corazza, Assigned: cedric.corazza)

Details

Attachments

(2 files)

Attached patch fr DOMi patchSplinter Review
fr DOMi update : adding accessibleRelations.dtd file landed with bug 347792.
Makefile.in is already up-to-date with fr added in the ALL_LOCALES list.
Benoît, please ask for approvalM9 if it's ok for you.
Attachment #286980 - Flags: review?(benoit.leseul)
Comment on attachment 286980 [details] [diff] [review]
fr DOMi patch

The translation looks fine to me.

Requesting approvalM9 as requested by Cédric.
Attachment #286980 - Flags: review?(benoit.leseul)
Attachment #286980 - Flags: review+
Attachment #286980 - Flags: approvalM9?
Comment on attachment 286980 [details] [diff] [review]
fr DOMi patch

Check with Axel for l10n checkin rules; we're not controlling these moment, and I believe the idea was to give locales at least 24h after M9 code freeze to get their updates in for M9

I think you can go ahead with this one.
Attachment #286980 - Flags: approvalM9?
Thanks Mike,
The situation concerning inspector is a bit weird, as this is about /l10n within the mozilla code tree...
Shawn, could you check this in please?
Keywords: checkin-needed
Comment on attachment 286980 [details] [diff] [review]
fr DOMi patch

Ugh, I thought this was in the l10n tree, but sdwilsh corrected me.

a=endgame drivers for M9
Attachment #286980 - Flags: approvalM9+
Attachment #286980 - Flags: approval1.9+
RCS file: /cvsroot/mozilla/extensions/inspector/resources/locale/fr/viewers/accessibleRelations.dtd,v
done
Checking in extensions/inspector/resources/locale/fr/viewers/accessibleRelations.dtd;
/cvsroot/mozilla/extensions/inspector/resources/locale/fr/viewers/accessibleRelations.dtd,v  <--  accessibleRelations.dtd
initial revision: 1.1
done
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Didn't see that fr locale was missing in the Makefile.in. This doesn't obsolete the previous patch and current fr trunk builds are not not broken, but DOM Inspector appears in English in the UI.
Is it too late in the game for the beta 1 release?
Attachment #287554 - Flags: approvalM9?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 287554 [details] [diff] [review]
Patch adding fr locale to Makefile.in

a=beltzner for M9 if you can get it in immediately
Attachment #287554 - Flags: approvalM9?
Attachment #287554 - Flags: approvalM9+
Attachment #287554 - Flags: approval1.9+
Checking in extensions/inspector/resources/Makefile.in;
/cvsroot/mozilla/extensions/inspector/resources/Makefile.in,v  <--  Makefile.in
new revision: 1.44; previous revision: 1.43
done
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.