Typo and inconsitency in installer's error messages

VERIFIED FIXED

Status

Mozilla Localizations
pl / Polish
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: marcoos, Assigned: marcoos)

Tracking

({verified1.8.1.20})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

11 years ago
Created attachment 287087 [details] [diff] [review]
Patch

As reported by Ptak82 in http://bugs.aviary.pl/show_bug.cgi?id=1280 - the translation of the "Retry" button in the error message is not consistent with the button itself. Also, due to a missing 'n' in what should be '\n', the first letter of the word 'Naciśnij' is not visible.

Screenshot: http://bugs.aviary.pl/attachment.cgi?id=924

This is fixed on trunk, but it would be nice to have it fixed in 2.0.0.10.
Attachment #287087 - Flags: approval1.8.1.10?
(Assignee)

Comment 1

11 years ago
Created attachment 287089 [details] [diff] [review]
Patch

Oops, the previous patch had a typo. :-)
Attachment #287087 - Attachment is obsolete: true
Attachment #287089 - Flags: approval1.8.1.10?
Attachment #287087 - Flags: approval1.8.1.10?

Comment 2

11 years ago
Comment on attachment 287089 [details] [diff] [review]
Patch

If we do not use quotation marks at "Anuluj" and at "Przerwij" - we should not use it at "Ponów próbę"
Attachment #287089 - Flags: review-
(Assignee)

Comment 3

11 years ago
Created attachment 287558 [details] [diff] [review]
Patch

...with review comments addressed.

We need to use quotes around multiple-word button names to avoid ambiguity. I have nothing against quoting single-word ones as well throughout pl l10n (in fact, I think it's the right thing to do for 3.0).

It would be even better for us to use the „ and ” quotes, but I'm not sure if these are safe for NSIS, esp. on legacy Windows versions...
Attachment #287089 - Attachment is obsolete: true
Attachment #287089 - Flags: approval1.8.1.10?
(Assignee)

Updated

11 years ago
Attachment #287558 - Flags: review?(hubert)

Comment 4

11 years ago
(In reply to comment #3)

> We need to use quotes around multiple-word button names to avoid ambiguity. I
> have nothing against quoting single-word ones as well throughout pl l10n (in
> fact, I think it's the right thing to do for 3.0).

Right, so we cannot change our rules at mozilla1.8 branch. I suggest do not add quotation marks now. Can you remove these signs from the patch?
(Assignee)

Comment 5

11 years ago
I suppose in this case clarity requires us to use the quotes. And for me, clarity is more important than consistency (esp. when it's consistency with something "not really right").

Comment 6

11 years ago
Comment on attachment 287558 [details] [diff] [review]
Patch

OK, so be it.
r=hubert
Attachment #287558 - Flags: review?(hubert) → review+
(Assignee)

Updated

11 years ago
Attachment #287558 - Flags: approval1.8.1.10?
Comment on attachment 287558 [details] [diff] [review]
Patch

missed 1.8.1.10
Attachment #287558 - Flags: approval1.8.1.10? → approval1.8.1.11?

Comment 8

11 years ago
Comment on attachment 287558 [details] [diff] [review]
Patch

[pl] translation fix approved for .12. Please use the fixed1.8.1.12 and verified1.8.1.12 keywords to track landing and testing.
Attachment #287558 - Flags: approval1.8.1.12? → approval1.8.1.12+
(Assignee)

Comment 9

10 years ago
Oops, how could I forget to check this in?

fixed1.8.1.12
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.12 → verified1.8.1.20
You need to log in before you can comment on or make changes to this bug.