Closed
Bug 402244
Opened 18 years ago
Closed 18 years ago
Page Info broken when opened from sidebar
Categories
(Firefox :: Page Info Window, defect)
Firefox
Page Info Window
Tracking
()
RESOLVED
FIXED
Firefox 3 beta2
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(2 files, 1 obsolete file)
|
2.24 KB,
patch
|
asaf
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
|
2.20 KB,
patch
|
db48x
:
review+
neil
:
superreview-
|
Details | Diff | Splinter Review |
Error: window.opener.gBrowser has no properties
Source File: chrome://browser/content/pageinfo/security.js
Line: 73
Attachment #287127 -
Flags: review?(mano)
Comment 1•18 years ago
|
||
Comment on attachment 287127 [details] [diff] [review]
patch v1
hrm, sp cannot be null if ui isn't (queryinterface throws). I kinda prefer
ui.QueryInterface(nsISSLStatusProvider);
status = ui.SSLStatus;
looks good otherwise.
Attachment #287127 -
Flags: review?(mano) → review+
| Assignee | ||
Comment 2•18 years ago
|
||
Attachment #287127 -
Attachment is obsolete: true
Updated•18 years ago
|
Attachment #287775 -
Flags: review+
| Assignee | ||
Updated•18 years ago
|
Attachment #287775 -
Flags: approval1.9?
Updated•18 years ago
|
Attachment #287775 -
Flags: approval1.9? → approval1.9+
| Assignee | ||
Updated•18 years ago
|
Keywords: checkin-needed
Comment 3•18 years ago
|
||
Checking in browser/base/content/pageinfo/security.js;
/cvsroot/mozilla/browser/base/content/pageinfo/security.js,v <-- security.js
new revision: 1.9; previous revision: 1.8
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M10
| Assignee | ||
Comment 4•18 years ago
|
||
Attachment #293248 -
Flags: superreview?(neil)
Attachment #293248 -
Flags: review?(db48x)
Comment 5•18 years ago
|
||
Comment on attachment 293248 [details] [diff] [review]
seamonkey port
r=db48x
Attachment #293248 -
Flags: review?(db48x) → review+
Comment 6•18 years ago
|
||
So what's the bug in suite here? As far as I can tell, view page info for a sidebar tab returns security status for the content area, and this patch makes view frame info do that too, which is incorrect as per bug 138479.
Comment 7•18 years ago
|
||
Comment on attachment 293248 [details] [diff] [review]
seamonkey port
I think we need a separate bug filed for suite.
Attachment #293248 -
Flags: superreview?(neil) → superreview-
You need to log in
before you can comment on or make changes to this bug.
Description
•