Don't nag about leaving an unsaved page if no changes have been made

VERIFIED FIXED

Status

task
--
minor
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: jason.barnabe, Assigned: jason.barnabe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tiki_test)

Attachments

(1 attachment)

Assignee

Description

12 years ago
If you go to edit a page and then navigate somewhere else without saving, the site will ask you whether you really want to do that. It shouldn't ask unless you've actually made some changes.
Assignee

Comment 1

12 years ago
Posted patch patchSplinter Review
With this patch, the user will not be prompted for confirmation if they're on the plain edit screen (not the preview screen) and the text of the main textarea has not changed.

This patch assumes jQuery is available at /js/jquery.js

Possibly upstream this?
Assignee: nobody → jason_barnabe
Status: NEW → ASSIGNED
Assignee

Updated

12 years ago
Attachment #287315 - Flags: review?(nelson)

Comment 2

12 years ago
hmm. TikiWiki uses MooTools instead of Jquery. Do you know how to do it using MooTools?
Assignee

Comment 3

12 years ago
I'm not familiar with MooTools, but I don't see why it couldn't be done. The only thing I used JQuery for in this patch is for the cross-browser window load event. I'll revise the patch to use MooTools if you don't get to it first.

Comment 4

12 years ago
can you try revising this for MooTools? I read somewhere on the web that MooTools has js vars that clash with JQuery. Not sure if that is true but if that is the case, and since MooTools is in Tiki, I rather not take the risk.
Comment on attachment 287315 [details] [diff] [review]
patch

review- based on comments
Attachment #287315 - Flags: review?(nelson) → review-
Assignee

Comment 6

11 years ago
New version using MooTools committed in r13461.
Assignee

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Assignee

Updated

11 years ago
Status: RESOLVED → VERIFIED

Updated

10 years ago
Whiteboard: tiki_triage

Comment 7

10 years ago
heh, Tiki now uses jQuery

And I think the feature was added. Let's test on http://tiki-trunk.mozilla.com/ and if it's not done, let's upstream.
Whiteboard: tiki_triage → tiki_test
You need to log in before you can comment on or make changes to this bug.